Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exeception when runtime is not active #1456

Closed
lifflander opened this issue May 27, 2021 · 0 comments · Fixed by #1457
Closed

Throw exeception when runtime is not active #1456

lifflander opened this issue May 27, 2021 · 0 comments · Fixed by #1457
Assignees

Comments

@lifflander
Copy link
Collaborator

Describe the bug
Right now, we aren't throwing if the runtime is not active, which occurs in the nompi tests.

Also, if it doesn't already work this way, we want to enable throwing on non-CI builds for all tests. But, we don't want to compile two different versions of the VT code. So this might be a bit tricky.

template <runtime::RuntimeInstType instance>
void CollectiveAnyOps<instance>::abort(
  std::string const str, ErrorCodeType const code
) {
  auto tls_rt = curRT;
  auto myrt = tls_rt ? tls_rt : ::vt::rt;
  if (myrt) {
#if vt_check_enabled(trace_enabled)
    //--- Try to flush most of the traces before aborting
    myrt->theTrace->cleanupTracesFile();
#endif
    myrt->abort(str, code);
  } else {
    std::_Exit(code);
  }

}
JacobDomagala added a commit that referenced this issue May 27, 2021
…tHarness to set app options without using vt::runtime
JacobDomagala added a commit that referenced this issue May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants