Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings by default #329

Closed
nlslatt opened this issue Mar 26, 2019 · 3 comments
Closed

Enable warnings by default #329

nlslatt opened this issue Mar 26, 2019 · 3 comments
Assignees
@nlslatt

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Mar 26, 2019

Turn on -Wall and -pedantic by default if supported by the compiler. Also turn on -Wno-variadic-macros and -Wno-gnu-zero-variadic-macro-arguments until #305 and darma-mpi-backend/meld#3 are closed.
@nlslatt nlslatt self-assigned this Mar 26, 2019
nlslatt added a commit that referenced this issue Mar 26, 2019
@nlslatt
#329: build: enable warnings by default
900a943
@nlslatt
Copy link
Collaborator Author

nlslatt commented Mar 26, 2019

This should work but I'm not submitting a PR until after #306.

@nlslatt nlslatt mentioned this issue Mar 26, 2019
Closed
nlslatt added a commit that referenced this issue Mar 27, 2019
@nlslatt
#329: turn off unknown pragma warnings
730a79d
@lifflander lifflander mentioned this issue Mar 27, 2019
Closed
nlslatt added a commit that referenced this issue Apr 5, 2019
@nlslatt
#329: enabling shadow warnings
4065504
nlslatt added a commit that referenced this issue Apr 5, 2019
@nlslatt
#329: build: enable warnings by default
b67361e
@nlslatt
Copy link
Collaborator Author

nlslatt commented Apr 5, 2019

The final set of warning flags used:

-Wall -pedantic -Wshadow -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-pragmas

(or the subset of these supported by the compiler being used).

@nlslatt nlslatt mentioned this issue Apr 5, 2019
Merged
@nlslatt
Copy link
Collaborator Author

nlslatt commented Apr 5, 2019

The associated PR is #348.

lifflander pushed a commit that referenced this issue Apr 16, 2019
@nlslatt @lifflander
#329: build: enable warnings by default
c6932ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlslatt nlslatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifflander @nlslatt