Feature 329 enable warnings by default #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifflander
approved these changes
Apr 16, 2019
lifflander
force-pushed
the
feature-329-enable-warnings
branch
from
b67361e to
c6932ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing warnings will be addressed by issues #306/#347 (the bulk), #340 (14 unique that amount to 1907), fmtlib/fmt#1105 (3 unique that amount to 606), #336 (5-14 depending on compiler), and #345 (2 unique that amount to 5), none of which have been merged at the time this PR is being submitted. @lifflander can decide at what point to merge this PR and make the remaining warnings visible to all.