Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctest pass criteria is too weak #519

Closed
nlslatt opened this issue Oct 25, 2019 · 1 comment
Closed

ctest pass criteria is too weak #519

nlslatt opened this issue Oct 25, 2019 · 1 comment

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Oct 25, 2019

Describe the bug

ctest labels segfaults as passes on Mutrino. e.g.,

291/876 Testing: vt:*/TestReduceCollection.test_reduce_op/*_proc_8
291/876 Test: vt:*/TestReduceCollection.test_reduce_op/*_proc_8
Command: "/opt/slurm/bin/mpiexec" "-n" "8" "./test_reduce_collection" "--gtest_filter=*/TestReduceCollection.test_reduce_op/*"
Directory: /home/nlslatt/vt-auto-build/with-tracing/vt/vt-build/tests
"vt:*/TestReduceCollection.test_reduce_op/*_proc_8" start time: Oct 25 13:55 MDT
Output:
----------------------------------------------------------
srun: error: nid00016: tasks 0-7: Segmentation fault
srun: Terminating job step 19287764.1226
<end of output>
Test time =   0.99 sec
----------------------------------------------------------
Test Passed.
"vt:*/TestReduceCollection.test_reduce_op/*_proc_8" end time: Oct 25 13:55 MDT
"vt:*/TestReduceCollection.test_reduce_op/*_proc_8" time elapsed: 00:00:00

To Reproduce

Run ctest suite on Mutrino and check Testing/Temporary/LastTests.log afterward for verbose output.

Expected behavior

Segfaults should be classified as test failures.

nlslatt added a commit that referenced this issue Oct 25, 2019
@nlslatt nlslatt self-assigned this Oct 25, 2019
lifflander pushed a commit that referenced this issue Oct 28, 2019
lifflander pushed a commit that referenced this issue Oct 28, 2019
@lifflander
Copy link
Collaborator

Closing, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants