519 fail on segfault #520
Merged
519 fail on segfault #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlslatt
requested review from
PhilMiller,
pnstickne,
lifflander and
uhetmaniuk
lifflander
approved these changes
Oct 26, 2019
lifflander
force-pushed
the
519-ctest-pass-criteria
branch
from
9a54103 to
a25f59c
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #519. On Mutrino at least, ctest doesn't notice segfaults unless I have it grep for "Segmentation fault", potentially because of using srun to launch the tests. With this improvement to the testing setup, I see that many unit tests and examples are segfaulting on Mutrino (whereas previously the segfaults were there but not brought to the user's attention). Note that I built with tracing and haven't checked to see how many of the segfaults are tracing-related.