Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more tests for various load models #959

Closed
lifflander opened this issue Jul 30, 2020 · 5 comments · Fixed by #1012
Closed

Add some more tests for various load models #959

lifflander opened this issue Jul 30, 2020 · 5 comments · Fixed by #1012
Assignees
@JacobDomagala
Labels
intro A potentially good introductory issue for a new developer to address type: task

Comments

@lifflander
Copy link
Collaborator

What Needs to be Done?

The PerCollection model is tested (along with couple other points in the model codepath), but mostly the load models lack any testing. Write unit tests for them.
@lifflander lifflander added type: task intro A potentially good introductory issue for a new developer to address labels Jul 30, 2020
@lifflander
Copy link
Collaborator Author

@JacobDomagala Can you work on this issue next? I want to get some more testing in place for the load models. If you have questions about how they are supposed to work, query me or @PhilMiller.

@JacobDomagala
Copy link
Contributor

JacobDomagala commented Aug 18, 2020 •
edited
Loading

Note to self following could be useful:

@lifflander lifflander mentioned this issue Aug 18, 2020
Open
@JacobDomagala
Copy link
Contributor

@lifflander @PhilMiller Let me know if you have any particular tests in mind for any of the load models. In the meantime i will study the code and docs to get more familiar with the topic and maybe will try to come with some useful tests aswell.

JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for NaivePersistance Load Model
a4ddc3e
@JacobDomagala JacobDomagala mentioned this issue Aug 24, 2020
Merged
4 tasks
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for NaivePersistence Load Model
8c5b757
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for NaivePersistence Load Model
38b2f54
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for NaivePersistence Load Model
3083f9b
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Fix calculation of median in PersistenceMedianLastN model and fi…
21b0d25 
…x ComposedModel::getNumCompletedPhases()
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for PersistenceMedianLastN Load Model
a083a9a
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for PersistenceMedianLastN Load Model
1f59b28
JacobDomagala added a commit that referenced this issue Aug 24, 2020
@JacobDomagala
#959 Add unittest for PersistenceMedianLastN Load Model
0f13dbc
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for PersistenceMedianLastN Load Model to be more…
5205376 
… isolated from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for PersistenceMedianLastN Load Model to be more…
d0ed839 
… isolated from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for PersistenceMedianLastN Load Model to be more…
7234f59 
… isolated from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for NaivePersistence Load Model to be more isola…
3ed5cc0 
…ted from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Add unittest for LinearModel
5afc2e1
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Add unittest for NaivePersistence Load Model
e57d31b
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Fix calculation of median in PersistenceMedianLastN model and fi…
8661c68 
…x ComposedModel::getNumCompletedPhases()
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Add unittest for PersistenceMedianLastN Load Model
3a99da9
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for PersistenceMedianLastN Load Model to be more…
48c34d1 
… isolated from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Update unittest for NaivePersistence Load Model to be more isola…
a56c2f6 
…ted from dependencies
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Add unittest for LinearModel
8840f33
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Add unittest for MultiplePhases Load Model
b6f0926
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Use setLoads() on tested model instead of base(stub model)
b04db1a
JacobDomagala added a commit that referenced this issue Aug 25, 2020
@JacobDomagala
#959 Change from TestParallelHarness to TestHarness for Load Models u…
a0938bc 
…nittests
JacobDomagala added a commit that referenced this issue Sep 2, 2020
@JacobDomagala
#959 Add unit tests for Norm load model
baf958b
JacobDomagala added a commit that referenced this issue Sep 2, 2020
@JacobDomagala
#959 Add unit test for CommOverhead load model
b79040f
JacobDomagala added a commit that referenced this issue Sep 2, 2020
@JacobDomagala
#959 Add unit tests for SelectSubphases load model
c7e252f
JacobDomagala added a commit that referenced this issue Sep 2, 2020
@JacobDomagala
#959 Use numeric_limits::infinity for infinite power argument in unit…
152542c 
… test for Norm load model
JacobDomagala added a commit that referenced this issue Sep 9, 2020
@JacobDomagala
#959 Add unit tests for Norm load model
9c6fa74
JacobDomagala added a commit that referenced this issue Sep 9, 2020
@JacobDomagala
#959 Add unit test for CommOverhead load model
340c4f9
JacobDomagala added a commit that referenced this issue Sep 9, 2020
@JacobDomagala
#959 Add unit tests for SelectSubphases load model
8229762
JacobDomagala added a commit that referenced this issue Sep 9, 2020
@JacobDomagala
#959 Use numeric_limits::infinity for infinite power argument in unit…
b4b61ac 
… test for Norm load model
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Update load model tests to call updateLoads()
8bf5397
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Update load model tests to call updateLoads()
409b4a5
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Add unit tests for Norm load model
fa1049f
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Add unit test for CommOverhead load model
26590f3
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Add unit tests for SelectSubphases load model
e2a2e90
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Use numeric_limits::infinity for infinite power argument in unit…
cee64dd 
… test for Norm load model
JacobDomagala added a commit that referenced this issue Sep 10, 2020
@JacobDomagala
#959 Update load model tests to call updateLoads()
8ebdd9d
JacobDomagala added a commit that referenced this issue Sep 11, 2020
@JacobDomagala
#959 Add unit tests for Norm load model
1ad9f0f
JacobDomagala added a commit that referenced this issue Sep 11, 2020
@JacobDomagala
#959 Add unit test for CommOverhead load model
9193340
JacobDomagala added a commit that referenced this issue Sep 11, 2020
@JacobDomagala
#959 Add unit tests for SelectSubphases load model
c6f27ef
JacobDomagala added a commit that referenced this issue Sep 11, 2020
@JacobDomagala
#959 Use numeric_limits::infinity for infinite power argument in unit…
aee3585 
… test for Norm load model
JacobDomagala added a commit that referenced this issue Sep 11, 2020
@JacobDomagala
#959 Update load model tests to call updateLoads()
3e0af58
lifflander added a commit that referenced this issue Sep 11, 2020
@lifflander
Merge pull request #1012 from DARMA-tasking/#959-add-unit-tests-for-l…
06deef2 
…oad-models-part-2

959 Add some more tests for various load models (Part 2)
JacobDomagala added a commit that referenced this issue Jan 12, 2021
@JacobDomagala
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
203b194
JacobDomagala added a commit that referenced this issue Jan 12, 2021
@JacobDomagala
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
e94fd94
nlslatt pushed a commit that referenced this issue Jan 13, 2021
@JacobDomagala @nlslatt
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
2e35284
nlslatt pushed a commit that referenced this issue Jan 19, 2021
@JacobDomagala @nlslatt
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
fe004a5
nlslatt pushed a commit that referenced this issue Jan 19, 2021
@JacobDomagala @nlslatt
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
ee63d98
nlslatt pushed a commit that referenced this issue Jan 19, 2021
@JacobDomagala @nlslatt
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
97f711b
nlslatt pushed a commit that referenced this issue Feb 26, 2021
@JacobDomagala @nlslatt
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
d6780e6
lifflander pushed a commit that referenced this issue Mar 8, 2021
@JacobDomagala @lifflander
#959 unittest: Fix incorrect elementIDs in comm_overhead unittest
a392bb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
intro A potentially good introductory issue for a new developer to address type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

959 Add some more tests for various load models (Part 2) DARMA-tasking/vt
3 participants
@PhilMiller @lifflander @JacobDomagala