959 Add some more tests for various load models (Part 2)

[JacobDomagala]

Fixes #959

Part 2 of adding unit tests for load models (part 1 -> #1001)

Add unit tests for following load models:

• - Norm
• - CommOverhead
• - SelectSubphases

[codecov]

Codecov Report

Merging #1012 into develop will increase coverage by 0.16%.
The diff coverage is 94.68%.

@@             Coverage Diff             @@
##           develop    #1012      +/-   ##
===========================================
+ Coverage    77.41%   77.57%   +0.16%     
===========================================
  Files          663      674      +11     
  Lines        25528    25775     +247     
===========================================
+ Hits         19762    19995     +233     
- Misses        5766     5780      +14     

Impacted Files	Coverage Δ
.../unit/collection/test_model_comm_overhead.nompi.cc	92.30% <92.30%> (ø)
...it/collection/test_model_select_subphases.nompi.cc	95.31% <95.31%> (ø)
tests/unit/collection/test_model_norm.nompi.cc	95.83% <95.83%> (ø)
src/vt/pipe/state/pipe_state.cc	52.63% <0.00%> (-23.69%)	⬇️
src/vt/pipe/pipe_manager_base.cc	91.42% <0.00%> (-2.86%)	⬇️
...it/pipe/test_callback_bcast_collection.extended.cc	96.66% <0.00%> (-0.21%)	⬇️
tests/unit/pipe/test_callback_func.cc	96.15% <0.00%> (-0.15%)	⬇️
...nit/pipe/test_callback_send_collection.extended.cc	98.01% <0.00%> (-0.12%)	⬇️
tests/unit/memory/test_memory_lifetime.cc	99.18% <0.00%> (-0.02%)	⬇️
tutorial/tutorial_1g.h	100.00% <0.00%> (ø)
... and 23 more

[PhilMiller]

This generally looks good. Thanks!

[cz4rs]

Looks good to me

[lifflander]

Looks great, let's rebase and merge

[lifflander]

I'm kicking off the extended tests for this one just to be sure. But, I think this is good.

[PhilMiller]

In light of the broader object lifecycle issue identified in #1034, could these tests have updateLoads() calls added in the appropriate spots.

[JacobDomagala]

In light of the broader object lifecycle issue identified in #1034, could these tests have updateLoads() calls added in the appropriate spots.

Updated.

[lifflander]

@JacobDomagala Can you rebase this so we can get it merged? The test failure looks spurious. I just re-ran it.

[lifflander]

Here is an overview of what got changed by this pull request:

Clones added
============
- tests/unit/collection/test_model_select_subphases.nompi.cc  13
- tests/unit/collection/test_model_comm_overhead.nompi.cc  3
- tests/unit/collection/test_model_norm.nompi.cc  15
         

See the complete overview on Codacy