1256: Create vt_trace_only option before creating trace-only CMake target #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobDomagala
force-pushed
the
1256-move-vt-trace-option-before-target-creation
branch
from
835e3b4 to
9aa7cd5
Compare
JacobDomagala
requested review from
nmm0,
lifflander,
jstrzebonski,
cz4rs and
PhilMiller
jstrzebonski
approved these changes
Feb 10, 2021
JacobDomagala
force-pushed
the
1256-move-vt-trace-option-before-target-creation
branch
from
9aa7cd5 to
7c3eaea
Compare
lifflander
reviewed
Feb 15, 2021
JacobDomagala
force-pushed
the
1256-move-vt-trace-option-before-target-creation
branch
from
7c3eaea to
efc6262
Compare
JacobDomagala
commented
Feb 16, 2021
| @@ -110,6 +110,11 @@ include(cmake/load_bundled_libraries.cmake) | |||
|
|
|||
| include(cmake/nvcc_no_deprecated_gpu_targets.cmake) | |||
|
|
|||
| option(vt_trace_only "Build VT with trace-only mode enabled" OFF) | |||
There was a problem hiding this comment.
I've also changed it to be disabled by default. I think it's better to only build it on demand.
|
@lifflander Docs are still valid. This change fixes the small bug when building VT with cmake, without using |
lifflander
approved these changes
Feb 16, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256
With this fix, it's no longer required to add -Dvt_trace_only