Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1256: Create vt_trace_only option before creating trace-only CMake target #1257

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ include(cmake/load_bundled_libraries.cmake)

include(cmake/nvcc_no_deprecated_gpu_targets.cmake)

option(vt_trace_only "Build VT with trace-only mode enabled" OFF)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also changed it to be disabled by default. I think it's better to only build it on demand.

if (vt_trace_only)
message(STATUS "Building additional target for VT in trace-only mode")
endif()

# Primary VT build
add_subdirectory(src)

Expand Down
5 changes: 0 additions & 5 deletions cmake/define_build_types.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@ else()
set(vt_feature_cmake_trace_enabled "0")
endif()

option(vt_trace_only "Build VT with trace-only mode enabled" ON)
if (vt_trace_only)
message(STATUS "Building additional target for VT in trace-only mode")
endif()

# This will be set to 1 during generation of cmake config for vt-trace target
set(vt_feature_cmake_trace_only "0")

Expand Down
3 changes: 1 addition & 2 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,12 @@ link_target_with_vt(
DEFAULT_LINK_SET
)

# Define and set up the different build types of VT

include(../cmake/trace_only_functions.cmake)
if (vt_trace_only)
create_trace_only_target()
endif()

# Define and set up the different build types of VT
include(../cmake/define_build_types.cmake)

target_include_directories(
Expand Down