Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1654: tests: split up LB parameterization to reduce time per test instance #1656

Merged
merged 1 commit into from
Jan 12, 2022
Merged

#1654: tests: split up LB parameterization to reduce time per test instance #1656

merged 1 commit into from
Jan 12, 2022
+32 −17

Conversation

lifflander
Copy link
Collaborator

Fixes #1654

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

PhilMiller
PhilMiller approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want/need to test all of the scatter strategies in GreedyLB?

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@codecov
Copy link

codecov bot commented Jan 12, 2022 •
edited
Loading

Codecov Report

Merging #1656 (5bf258c) into develop (a4e8127) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1656   +/-   ##
========================================
  Coverage    83.49%   83.50%           
========================================
  Files          794      794           
  Lines        30775    30784    +9     
========================================
+ Hits         25697    25706    +9     
  Misses        5078     5078
Impacted Files Coverage Δ
tests/unit/collection/test_lb.extended.cc 87.13% <100.00%> (+0.49%) ⬆️

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 5bf258c

Compilation - successful

Testing - passed

Build log

cz4rs
cz4rs approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lifflander
#1654: tests: split up LB parameterization to reduce time per test in…

Unverified

No user is associated with the committer email.
Learn about vigilant mode
5bf258c 
…stance
@lifflander lifflander force-pushed the 1654-split-test-to-avoid-timeout branch from 166a451 to 5bf258c Compare January 12, 2022 18:06
@lifflander lifflander merged commit f88c3ba into develop Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller

@cz4rs cz4rs

@JacobDomagala JacobDomagala

@jstrzebonski jstrzebonski

@nlslatt nlslatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load Balancer tests are timing out
5 participants
@lifflander @PhilMiller @cz4rs @JacobDomagala @jstrzebonski