-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1970: release 1.2.0
#1985
Merged
Merged
1970: release 1.2.0
#1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-less-expensive 1764 make phase transition less expensive
…ld-name 1892 Add ref in CDash build name
1905: migrate CI builds using ubuntu-18.04 runner image to ubuntu-22.04
icpc 2021.6.0 shows following warning: `#3280: declaration hides variable "optarg" (declared at line 36 of "/usr/include/x86_64-linux-gnu/bits/getopt_core.h")`
1902: upgrade `CLI11` to `v2.2.0`
…-in-tests 1896 Use only unique filenames in unit tests
…rator 1918 Allow alternate cmake generator for gitlab CI
…essdata-in-am-early 1910 Break out early
…scheduler-triggers 1915 Cache TD pointer
…preconfig-evaluation #1908: Disable preConfig
This is a long-standing bug that started showing up with the changes in #1899, making the runnable more efficient. TestGroup.test_group_range_construct_2 was consistently breaking on the gcc-8 build with address sanitizer. With extensive debugging, I tracked this bug down to the lack of propagation of an epoch on the remote group construction message when a rooted group is constructed where the constructing node is not included. Additionally, the group must be specified by a list (not a range). When these conditions occur, the group manager sends the information about the group to a remote node using a packed put, which uses the `PayloadMessage`: namely, ` struct GroupListMsg : GroupInfoMsg<GroupMsg<::vt::PayloadMessage>>`. The `PayloadMessage`, using a default template parameter, uses a basic envelope which is not large enough to store the epoch. Thus, it gets dropped. Therefore, the test sometimes breaks because the group construction and following broadcast escape the `runInEpochCollective` and the test condition will fail sometimes as it races with the delivery of the group message being broadcast to the group spanning tree.
…-allocation-performance-new-variant 1899 Improve performance of Runnable and surrounding machinery
…ations #1974: fix various c++17 deprecations
…pi_wtime-calls-when-schedulerprogress-features-are-disabled #1969: scheduler: reduce calls to get the current time
741065e
to
6682a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1970