#2071: make pre-worker-removal init call deprecated #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation function that takes in the worker count but make them deprecated to avoid breaking existing code
PhilMiller
approved these changes
Jan 18, 2023
|
I think some things are failing because of the unity builds |
…ation caused deprecation warnings on some compilers
nvm it was just an inconsistency between the ways that compilers different compilers handled things |
Codecov Report
@@ Coverage Diff @@
## develop #2072 +/- ##
===========================================
- Coverage 84.77% 84.74% -0.04%
===========================================
Files 721 722 +1
Lines 25598 25600 +2
===========================================
- Hits 21701 21694 -7
- Misses 3897 3906 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2071