Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2071: make pre-worker-removal init call deprecated #2072

Merged
merged 2 commits into from
Jan 19, 2023
+10 −0
Merged

#2071: make pre-worker-removal init call deprecated #2072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a509a
#2071: add back in `no_workers`, `WorkerCountType`, and the initializ…
nmm0 Jan 18, 2023
741c87b
#2071: remove `WorkerCountType` since using it in a deprecated declar…
nmm0 Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/vt/collective/collective_ops.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ struct CollectiveAnyOps {
int& argc, char**& argv, bool is_interop = false, MPI_Comm* comm = nullptr,
arguments::AppConfig const* appConfig = nullptr
);
[[deprecated]] static RuntimePtrType initialize(
int& argc, char**& argv, PhysicalResourceType const /* num_workers */,
bool is_interop = false, MPI_Comm* comm = nullptr,
arguments::AppConfig const* appConfig = nullptr
)
{
return initialize(argc, argv, is_interop, comm, appConfig);
}
static void finalize(RuntimePtrType in_rt = nullptr);
static void scheduleThenFinalize(RuntimePtrType in_rt = nullptr);
static void setCurrentRuntimeTLS(RuntimeUnsafePtrType in_rt = nullptr);
Expand Down
2 changes: 2 additions & 0 deletions src/vt/configs/types/types_sentinels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ namespace vt {
// Physical identifier sentinel values (nodes etc.)
static constexpr NodeType const uninitialized_destination = static_cast<NodeType>(0xFFFF);

static constexpr PhysicalResourceType const no_workers [[deprecated]] = static_cast<PhysicalResourceType>(0xFFFF);

// Runtime default `empty' sentinel value
static constexpr uint64_t const u64empty = 0xFFFFFFFFFFFFFFFF;
static constexpr uint32_t const u32empty = 0xFEEDFEED;
Expand Down