554 demangler parsing fixes for tracing #578

pnstickne · 2019-11-19T07:16:31Z

Basic idea of unification and pushing out responsibilities. Still need to wire in the arguments.

Drafted to 554 as a pre-req.

Fixes #554

src/vt/registry/auto/auto_registry_general.h

+    return &proxyOperatorToNewInstanceReg<ObjType, Args...>;
+  }
+
+  static std::string traceGetEventType() {


src/vt/registry/auto/auto_registry_general.h

+  static std::string traceGetEventName() {
+    using TE = vt::util::demangle::TemplateExtract;
+    using DU = vt::util::demangle::DemanglerUtils;
+    //auto args = DU::join(",", TE::getTypeNames<Args...>());


pnstickne · 2019-11-19T18:59:34Z

src/vt/registry/auto/auto_registry_general.h

+  }
+
+  static size_t getNumArgs() {
+    return 0; // lies - see NumArgsTag, perhaps


Is used/relevant for these types? :-/

pnstickne · 2019-11-19T19:00:28Z

src/vt/registry/auto/auto_registry_general_impl.h

 }

-template <typename ActFnT, typename RegT, typename InfoT, typename FnT>
+template <typename RunnableT, typename RegT, typename InfoT, typename FnT>


Runnable-needs-Adapter (RunnableT::AdapterType), both are separate template types.

src/vt/registry/auto/functor/auto_registry_functor_impl.h

src/vt/registry/auto/auto_registry_general.h

-  auto operator()(A&&... a) -> decltype(auto) {
-    return f(std::forward<A>(a)...);
-   }
+  static std::string traceGetEventType() {


src/vt/registry/auto/auto_registry_general.h

+/// - FunctionPtrType
+/// - ObjType
+/// - getFunction
+/// - traceGetEventType


src/vt/registry/auto/auto_registry_general.h

pnstickne · 2019-11-23T06:21:02Z

@lifflander This is ready to go. I would merge this as it also includes the #575 issues and fixes SEGV's that occur in several examples (including 'reduce).

Only one test fails locally, and I believe that to be a test consistency issue (sometimes is it transpose_4, transpose_8, or both).

99% tests passed, 1 tests failed out of 681

Total Test time (real) = 89.61 sec

The following tests FAILED:
132 - vt:transpose_8 (Failed)
Errors while running CTest
make: *** [test] Error 8

For reference, prior..

93% tests passed, 51 tests failed out of 681

Total Test time (real) = 1170.20 sec

src/vt/registry/auto/functor/auto_registry_functor_impl.h

pnstickne · 2019-11-26T03:35:32Z

@lifflander Back-merged in 575.

lifflander · 2019-11-27T19:45:30Z

I just rebased this on latest develop and changed the target.

/Users/jliffla/codes/vt/virtual-transport/src/vt/utils/demangle/demangle.cc:159:9: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
  if (e >= 0 && typestr[e] == ')') {
      ~ ^  ~
1 warning generated.

@pnstickne Can you fix this warning? I'm not sure if there is actually a bug here or if this just needs to be removed?

lifflander

This looks great and I'm ready to merge this once the warning is resolved.

pnstickne · 2019-11-30T03:06:48Z

Warning should be gone (it was a minor bug for an edge-case that is 'never expected to be reached' as it would require empty input after removing void ().

pnstickne · 2019-12-03T18:40:34Z

Super super recommend. It also means that I can run tests with tracing mode enabled 💃

pnstickne · 2019-12-08T20:53:23Z

@lifflander
Having this in whatever main WIP would be so handy to avoid "random yet predictable crashes" failures during startup of various programs that hinder other development due to needing to have tracing disabled at compile-time.

- Push concerns outward so that each implemnentation can correctly sort out what it needs to do. (Previously some auto-reg that supplied a functor could bypass any internal wrappers making for split paths.) Also makes code a WEEEE bit easier to follow.

- Now that extensibility points have been pushed down, most of the special parsing code can be entirely eliminated. There only needs to remain some minimal support. It MAY also be possible to use type_id in SOME cases; however, the capture of the VALUE is probably not possible outside of __PRETTY_FUNCTION__ magic..

- Using the new contracts and extractors, wire in!

- Should now mostly parity the initial (and SEGV-happy) implementation that did lots of magical parsing.. ..only "a small bit" of string magic is done with the new impl. - Added some template 'overloads' as GCC was having a hard time (as in, not being able to and raising errors) the template values for TemplateA<T,T*> calling TemplateB<T,T>.

- Ensuring names are consistent to intent/usage

- Compiles in clang.. note the awesome "1 arg" case to avoid a clang COMPILER CRASH. Pretty awesome!?!

- Using NumArgsType instead of size_t, as per.. what should have been done. - Also removed some spurious spaces returned to make results more consistent overall.

- Simple recursive iterator to deal better with template parameters involved in various types.

- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..

- Seriously, I aready wrote and lost a commit message.

- Call to 'getFunction' is done directly on AdapterType - Removed '&' and specified type for simplicity/clarity (oops! force update with correction.. go compilation flags)

- While this case should 'never' be hit, it did lead to a valid compiler warning due to the unsigned nature of size_t.

pnstickne requested a review from lifflander November 19, 2019 07:16

pnstickne force-pushed the 554-demangler-chk branch from 141f1bd to d713b20 Compare November 19, 2019 17:10

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/auto_registry_general.h

return &proxyOperatorToNewInstanceReg<ObjType, Args...>;

}

static std::string traceGetEventType() {

This comment was marked as outdated.

Sign in to view

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/functor/auto_registry_functor_impl.h Show resolved Hide resolved

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/auto_registry_general.h Outdated Show resolved Hide resolved

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/auto_registry_general.h

auto operator()(A&&... a) -> decltype(auto) {

return f(std::forward<A>(a)...);

}

static std::string traceGetEventType() {

This comment was marked as resolved.

Sign in to view

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/auto_registry_general.h

/// - FunctionPtrType

/// - ObjType

/// - getFunction

/// - traceGetEventType

This comment was marked as outdated.

Sign in to view

pnstickne commented Nov 19, 2019

View reviewed changes

src/vt/registry/auto/auto_registry_general.h Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

pnstickne force-pushed the 554-demangler-chk branch from d713b20 to 9051b87 Compare November 22, 2019 05:24

pnstickne marked this pull request as ready for review November 22, 2019 09:33

pnstickne requested review from nmm0 and uhetmaniuk November 22, 2019 09:33

This comment has been minimized.

Sign in to view

pnstickne requested a review from PhilMiller November 23, 2019 06:23

lifflander force-pushed the 575-event-registry-bugs branch from 0e8f927 to 05d527b Compare November 25, 2019 18:33

lifflander assigned pnstickne Nov 25, 2019

lifflander added the 1.0.0-beta.5 label Nov 25, 2019

pnstickne commented Nov 26, 2019

View reviewed changes

src/vt/registry/auto/functor/auto_registry_functor_impl.h Show resolved Hide resolved

pnstickne force-pushed the 554-demangler-chk branch from abfc472 to a66f4c8 Compare November 26, 2019 03:42

lifflander added this to the 1.0.0-beta milestone Nov 26, 2019

lifflander force-pushed the 554-demangler-chk branch from a66f4c8 to 137d0a4 Compare November 27, 2019 19:45

lifflander changed the base branch from 575-event-registry-bugs to develop November 27, 2019 19:45

lifflander changed the title ~~554 demangler chk~~ 554 demangler parsing fixes for tracing Nov 27, 2019

lifflander approved these changes Nov 27, 2019

View reviewed changes

lifflander force-pushed the 554-demangler-chk branch from 901e76f to bf5f33a Compare November 30, 2019 07:39

pnstickne and others added 13 commits December 10, 2019 09:29

#554 unify Auto-Reg adaptors

5e38966

- Push concerns outward so that each implemnentation can correctly sort out what it needs to do. (Previously some auto-reg that supplied a functor could bypass any internal wrappers making for split paths.) Also makes code a WEEEE bit easier to follow.

#554 wire trace extraction in auto registry

c1465da

- Using the new contracts and extractors, wire in!

#554 rename template types (eg) for uniformity

76b26b5

- Ensuring names are consistent to intent/usage

#554 fix getTypeNames to report operator(Args...) cases

59e862a

- Compiles in clang.. note the awesome "1 arg" case to avoid a clang COMPILER CRASH. Pretty awesome!?!

#554 fix type narrowing and residue spaces

87cccab

- Using NumArgsType instead of size_t, as per.. what should have been done. - Also removed some spurious spaces returned to make results more consistent overall.

#554 improve namespace/type 'parsing'

8cec6f0

- Simple recursive iterator to deal better with template parameters involved in various types.

#544 use initializer list to get arg values..

2683e2e

- Doesn't crash Clang - Doesn't require recursive templates - Not sure why this is not mentioned more online..

#554 minor cleanup wrt events

7a15f74

- Seriously, I aready wrote and lost a commit message.

#554: cleanup; remove unused function, const-ref

8e30dd3

- Call to 'getFunction' is done directly on AdapterType - Removed '&' and specified type for simplicity/clarity (oops! force update with correction.. go compilation flags)

#554: registry: fix some rebase issues

1a40f9c

#554 fix small error in comparisson

4ab57d5

- While this case should 'never' be hit, it did lead to a valid compiler warning due to the unsigned nature of size_t.

lifflander force-pushed the 554-demangler-chk branch from bf5f33a to 4ab57d5 Compare December 10, 2019 17:29

lifflander merged commit ea32b4e into develop Dec 10, 2019

cz4rs mentioned this pull request Jun 15, 2021

move vt version number into a separate file #1467

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

554 demangler parsing fixes for tracing #578

554 demangler parsing fixes for tracing #578

pnstickne commented Nov 19, 2019 •

edited by lifflander

Loading

This comment was marked as outdated.

This comment was marked as outdated.

pnstickne Nov 19, 2019

pnstickne Nov 19, 2019

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

pnstickne commented Nov 23, 2019 •

edited

Loading

pnstickne commented Nov 26, 2019

lifflander commented Nov 27, 2019

lifflander left a comment

pnstickne commented Nov 30, 2019 •

edited

Loading

pnstickne commented Dec 3, 2019

pnstickne commented Dec 8, 2019 •

edited

Loading

554 demangler parsing fixes for tracing #578

554 demangler parsing fixes for tracing #578

Conversation

pnstickne commented Nov 19, 2019 • edited by lifflander Loading

This comment was marked as outdated.

This comment was marked as outdated.

pnstickne Nov 19, 2019

Choose a reason for hiding this comment

pnstickne Nov 19, 2019

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

pnstickne commented Nov 23, 2019 • edited Loading

pnstickne commented Nov 26, 2019

lifflander commented Nov 27, 2019

lifflander left a comment

Choose a reason for hiding this comment

pnstickne commented Nov 30, 2019 • edited Loading

pnstickne commented Dec 3, 2019

pnstickne commented Dec 8, 2019 • edited Loading

pnstickne commented Nov 19, 2019 •

edited by lifflander

Loading

pnstickne commented Nov 23, 2019 •

edited

Loading

pnstickne commented Nov 30, 2019 •

edited

Loading

pnstickne commented Dec 8, 2019 •

edited

Loading