Flatten arrays in ravel evaluation #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 96.36% 97.68% +1.31%
==========================================
Files 51 32 -19
Lines 2832 1855 -977
==========================================
- Hits 2729 1812 -917
+ Misses 103 43 -60 ☔ View full report in Codecov by Sentry. |
Cadair
force-pushed
the
flatten-ravel-arrays
branch
from
31c98ea to
996d43f
Compare
Otherwise it breaks real hard when you try to pass multiple points into pixel_to_world, because of array broadcasting
Cadair
force-pushed
the
flatten-ravel-arrays
branch
from
996d43f to
5d6b252
Compare
Cadair
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it breaks real hard when you try to pass multiple points into
pixel_to_world, because of array broadcasting. This was causingDataset.axis_world_coords()to have a meltdown. As far as I can tell this change fixes that behaviour without impacting anything else.