Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten arrays in ravel evaluation #309

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Flatten arrays in ravel evaluation #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
674ba43
Flatten arrays in ravel evaluation
SolarDrew Nov 3, 2023
398f7b2
Only flatten items if they're actually arrays (just in case they aren't)
SolarDrew Nov 6, 2023
5d6b252
Add changelog
SolarDrew Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/309.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix broadcasting issues during pixel -> world conversion for models with a Ravel component.
1 change: 1 addition & 0 deletions dkist/wcs/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@
else:
has_units = False
input_values = inputs_
input_values = [item.flatten() if isinstance(item, np.ndarray) else item for item in input_values]

Check warning on line 638 in dkist/wcs/models.py

View check run for this annotation

Codecov / codecov/patch

dkist/wcs/models.py#L638 

Added line #L638 was not covered by tests
# round the index values, but clip them if they exceed the array bounds
# the bounds are one less than the shape dimension value
array_bounds = np.array(self.array_shape) - 1
Expand Down
Loading