Improve performance of VaryingCelestialTransform #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
changed the title
Cadair
approved these changes
May 8, 2024
CodSpeed Performance ReportMerging #370 will improve performances by ×2.9Comparing Summary
Benchmarks breakdown
|
WHAT THAT WAS NOT THE EFFING POINT 🤦 |
|
hahaha |
Ok that's much closer to what I expected. I declare this PR ready for review |
SolarDrew
added a commit
to SolarDrew/dkist
that referenced
this pull request
May 17, 2024
improvements from DKISTDC#370
Merged
Cadair
pushed a commit
to SolarDrew/dkist
that referenced
this pull request
Jul 11, 2024
improvements from DKISTDC#370
Cadair
pushed a commit
to SolarDrew/dkist
that referenced
this pull request
Jul 17, 2024
improvements from DKISTDC#370
Cadair
added a commit
that referenced
this pull request
Jul 18, 2024
* Try slower plot again to see how it does now with performance improvements from #370 * Don't need both fixtures in this test any more * Don't need this old stuff either * Use more points for pixel_to_world benchmark * Add some more benchmarks * Need units on parameters for updating vct some of the time Not sure how this snuck past the tests in the first place * Benchmarks are taking too long again * Nope too slow * Benchmark dataset slicing * Add changelog * Try slower plot again to see how it does now with performance improvements from #370 * Don't need both fixtures in this test any more * Don't need this old stuff either * Use more points for pixel_to_world benchmark * Add some more benchmarks * Need units on parameters for updating vct some of the time Not sure how this snuck past the tests in the first place * Benchmarks are taking too long again * Nope too slow * Benchmark dataset slicing * Add changelog * Update dkist/wcs/models.py Co-authored-by: Stuart Mumford <[email protected]> * Add tests to hit update_celestial_transform and make sure the units are working sensibly * Correct test comparison value --------- Co-authored-by: Stuart Mumford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly re-jig VaryingCelestialTransform to strip units from the inputs in
._map_transform()and then put them back afterwards. Gives a reasonable performance boost, about 3.5x faster to plot a dataset across non-optimal axes.