-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more benchmarks #387
Merged
Merged
Add more benchmarks #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improvements from DKISTDC#370
CodSpeed Performance ReportMerging #387 will not alter performanceComparing Summary
Benchmarks breakdown
|
Not sure how this snuck past the tests in the first place
Not sure what else really needs benchmarking, suggestions welcome. Otherwise this is good to go. |
7b252d3
to
f7b9fef
Compare
Cadair
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small tweak otherwise I think this is good.
improvements from DKISTDC#370
Not sure how this snuck past the tests in the first place
Co-authored-by: Stuart Mumford <[email protected]>
a38bcd6
to
29aa7c8
Compare
Cadair
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try slower plot again to see how it does now with performance improvements from #370. I don't expect this to be merged soon, or even worked on necessarily, but I'm interested to see how fast we can get the longer plots running.Turns out the improvements haven't made enough difference to the performance to be able to use the slower plots so this has just become a PR to add some extra benchmarks. Will work on more performance improvements another time and try and use the slower plots when possible.