Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more benchmarks #387

Merged
merged 28 commits into from
Jul 18, 2024
Merged

Add more benchmarks #387

merged 28 commits into from
Jul 18, 2024

Conversation

SolarDrew
Copy link
Contributor

@SolarDrew SolarDrew commented May 17, 2024

Try slower plot again to see how it does now with performance improvements from #370. I don't expect this to be merged soon, or even worked on necessarily, but I'm interested to see how fast we can get the longer plots running.

Turns out the improvements haven't made enough difference to the performance to be able to use the slower plots so this has just become a PR to add some extra benchmarks. Will work on more performance improvements another time and try and use the slower plots when possible.

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #387 will not alter performance

Comparing SolarDrew:benchmarking-codspeed (275bd42) with main (f2d8e79)

Summary

✅ 3 untouched benchmarks

🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main SolarDrew:benchmarking-codspeed Change
🆕 test_generate_celestial N/A 5.2 ms N/A
🆕 test_raveled_tab1d_model N/A 1.1 ms N/A
🆕 test_slice_dataset N/A 65.1 ms N/A
🆕 test_update_celestial N/A 610.7 µs N/A

@SolarDrew
Copy link
Contributor Author

Not sure what else really needs benchmarking, suggestions welcome. Otherwise this is good to go.

@SolarDrew SolarDrew changed the title More benchmarking tweaks Add more benchmarks Jun 7, 2024
@Cadair Cadair force-pushed the benchmarking-codspeed branch from 7b252d3 to f7b9fef Compare July 11, 2024 15:39
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small tweak otherwise I think this is good.

@Cadair Cadair force-pushed the benchmarking-codspeed branch from a38bcd6 to 29aa7c8 Compare July 17, 2024 13:34
@Cadair Cadair enabled auto-merge (squash) July 18, 2024 09:23
@Cadair Cadair merged commit dab245f into DKISTDC:main Jul 18, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants