-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did you know? Subfolders and load times... #20
Comments
Uuuuuh... I guess. I'm not quite sure... scratches head semi-confusedly |
Doesn't it annoy you that the .git folder shows up in the SR2 mod editor? Wouldn't you like it to just keep out of your way? :) If so, then Support Proposal #20 Today! |
Heh, I dealt with that particular issue in the (now-broken) modding toolkit. Anyway, I'm mostly unsure about the technical details of the implementation (as in, 'what the hell is he talking about' - I'm probably only around 90% sure I figured it out), not whether it's worth doing. |
Tried it with a soft link. Not only did it insist that every file had been deleted and replaced (rather than renamed), it also failed to stage the files because of the symlink (for whatever reason). :/ |
mklink /J "%repoPath%%modName%" "X:\Steam\steamapps\common\Star Ruler 2\mods%modName%" is the command I use, with appropriate variables filled in obviously. Were you using Junction? It's the only one that's transparent to file systems and things. I'll have a go myself at some point. |
Ahh, junctions. I'll try that next time - I went with /D. |
AAAAAAAARGH. Stupid Git client marked it as a 'rename' and then just 'added' the damn thing. (And to add insult to injury, it didn't 'remove' the old files!) |
Thing is ,git is not slowing the loads (to the point to the 60s compile )I already tryed deleting the git folder when the mod was slow.And did not improve. pd:hope i am wrong tho.But i still think that moving files around is what fixed it. |
I suggest you call your mod folder 'ABEM', but symlink it into 'Rising Stars'. That way, when you edit locale files, you'll edit the ABEM_%stuff% locale files instead of creating a new one. |
Alas, no, it won't work that way :) Star Ruler 2 will still see it as Rising Stars, so it'll use those locale files. It's only Git that will see it as ABEM, and that won't help all that much. Since the mod is literally called Rising Stars, SR2 is always going to see it that way - it's in the mod info :) On the plus side that makes all the stuff I write nicely collated together, and you or I can just merge them into the main ones whenever you or I feel it appropriate. |
Nope, it's not the modinfo. I know from experience - I've had 'ABEM', 'ABEMGit', 'ABEMGitNew', and whatever folder names Alar came up with. If your mod folder is called 'ABEM', SR2 will use ABEM_%stuff%. If your folder is called 'Rising Stars', which it apparently is, SR2 will use 'Rising Stars_%stuff%' - as it already has for you. |
Huh. Well, fair enough, but... if we're renaming the project to Rising Stars sly grin why don't we just rename all the locale files too? (Sorry, sorry! ^_^) Dalo: Because. :P |
Oh right. I had a more useful comment. Here are the steps for someone new to clone the repo and set up the symbolic junction link. (And yes, if you're wondering I still think of final fantasy 8 every time I use one.)
For me, using these examples, the entire line including the command prompt location is: X:\Projects\Sourcecontrol\SR2-RisingStars>mklink /J "Rising Stars" "X:\Steam\steamapps\common\Star Ruler 2\mods\Rising Stars" After performing all of these steps, reload your git client and it should work as normal, but you won't be bothered by .git files getting into the SR2 mod editor, and neither is there any possibility they'll be uploaded to steam. |
Linux users: Instead of the syntax
|
If you put your mod in a subfolder, with the .git folder at the TOP level, you can then use a symbolic link to get it as a local repository without ever having any of the .git stuff touch the actual mod folder in the Star Ruler 2/mods folder.
That means you can accumulate all of the various changes without SR2 taking ages to load because .git stores chunks of the project history as hashes in there.
I realize that now is not the -ideal- time to suggest this, but it's the best time there will ever be from now forwards, as it's only going to get more annoying to re-directory it in future.
Here's an example:
that shortcut looking thing is actually a symbolic link, so from git's perspective, everything in the Building Assortment folder is a subfolder of the SR2-BuildingAssortment folder in my SourceControl folder.
Meanwhile, the Building Assortment folder is actually/simultaneously at steam/blah/Star Ruler 2/mods/Building Assortment, so I physically cannot accidentally upload my .git to the steam workshop because it's not in the folder tree that SR2 can actually see.
I tried to set this up for my local copy of Rising-Star, but it won't work without the subfolder.
Do you think it's a worthwhile idea?
Having investigated, there IS a way to convince Git to do this and maintain file histories, it will be treated as if every file in the entire repo has been renamed (to include the longer file path). If we are very careful to have a clean, easy master before we go renaming everything, and as long as that rename is the ONLY change in that commit, it should be quite plausible to do this merge without breaking anything.
What do you think?
^_^ eheh...
The text was updated successfully, but these errors were encountered: