Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-616] Unbreak the test action due to datarepo-helm action running #1805

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

fboulnois
Copy link
Contributor

## Addresses

https://broadworkbench.atlassian.net/browse/DCJ-616

## Summary

In TDR, Changes were recently made to the action which runs on PRs:

- #1781 
- #1794

The workflow in broadinstitute/datarepo-helm#276 tries to (unsuccessfully) modify the action, breaking it in the process:

31b4714

Links to failed builds:

https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708679629
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708678706
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708668823

It added this little piece at the bottom which breaks the action.
@fboulnois fboulnois requested review from a team as code owners September 4, 2024 20:20
@fboulnois fboulnois requested review from rushtong and removed request for a team September 4, 2024 20:20
@okotsopoulos okotsopoulos self-requested a review September 4, 2024 20:21
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I understand now :)

@fboulnois fboulnois changed the title [DCJ-616] Unbreak the test action due to helm action running [DCJ-616] Unbreak the test action due to datarepo-helm action running Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@fboulnois fboulnois merged commit 0ffb031 into develop Sep 4, 2024
10 checks passed
@fboulnois fboulnois deleted the fb-dcj-614-unbreak-test-action branch September 4, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants