Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-616] Do not update action anymore #276

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

@okotsopoulos okotsopoulos self-requested a review September 4, 2024 20:16
@fboulnois fboulnois requested a review from rushtong September 4, 2024 20:16
Copy link
Member

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm a little confused that we are hitting this issue before the integration test refactor PR has been merged, can you help me see what I'm missing?

fboulnois added a commit to DataBiosphere/jade-data-repo that referenced this pull request Sep 4, 2024
## Addresses

https://broadworkbench.atlassian.net/browse/DCJ-616

## Summary

In TDR, Changes were recently made to the action which runs on PRs:

- #1781 
- #1794

The workflow in broadinstitute/datarepo-helm#276 tries to (unsuccessfully) modify the action, breaking it in the process:

31b4714

Links to failed builds:

https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708679629
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708678706
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708668823

It added this little piece at the bottom which breaks the action.
Copy link
Contributor

@snf2ye snf2ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!!

@fboulnois fboulnois merged commit e31c33b into master Sep 4, 2024
1 check passed
@fboulnois fboulnois deleted the fb-dcj-616-do-not-update-action branch September 4, 2024 20:22
fboulnois added a commit to DataBiosphere/jade-data-repo that referenced this pull request Sep 4, 2024
…#1805)

Update int-and-connected-test-run.yml

## Addresses

https://broadworkbench.atlassian.net/browse/DCJ-616

## Summary

In TDR, Changes were recently made to the action which runs on PRs:

- #1781 
- #1794

The workflow in broadinstitute/datarepo-helm#276 tries to (unsuccessfully) modify the action, breaking it in the process:

31b4714

Links to failed builds:

https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708679629
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708678706
https://github.com/DataBiosphere/jade-data-repo/actions/runs/10708668823

It added this little piece at the bottom which breaks the action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants