added windows agent installation support #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #142 |
added windows agent installation support
updated for travis build
updated for unusual exception
updates for travis ci
Signed-off-by: Arthur Neves <[email protected]>
We no longer use Vagrant directly to test, perferrring test-kitchen and associated drivers.
The latest version doesn't appear to change anything backwards-breaking, considering our rules. The rules have been updated for namespace, as well as exclusion of code that does not belong to us.
In 4.1, a slightly updated syntax requires a choice of SoloRunner vs ServerRunner. Using SoloRunner is the faster test utility. Adds a few shared examples, and refactors the use cases to be more generalized and behavior more shared, so the combination of platforms, versions, and attributes can be tested. This could be improved further.
After multiple passes at attempting to cover all cases of inclusion of instance details into a given YAML file, this lays the foundation for leaving the details up to the end-user to implement the instance hash, instead of trying to capture each possible flag. This should help future-proof the recipe and template, so any new flags can be appended as data. See #88, #93 and fixes #116, #121. Tests and examples updated.
Adds a deprecation note to the languages detector, as we no longer depend on python at all. Minor docs updates.
Closes #129 [ci skip]
Saves some boilerplate
This should reduce the amount of Gems a CI service will have to install
Gem was released a bit ago, and is now conflicting on dependencies when bundling.
While EOL is Feb 23, 2015, removing this now allows testing without having to accommodate odd ohai installation behaviors. https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/
- Major cleanup of key:value setting and exclusion. Simplified for arbitrary entry inclusion. - Allow the `host` attribute to be set if named `server` for backwards compat. - Add integration tests Refs #154
The auto-generated suite names from test-kitchen convert underscores to dashes, so the task output should display the correct name instead of me spending 5 minutes wondering why it didn't work.
This is a way to DRY up some of the repeated attributes that are global to all tests, as well as allow replacement in one place with a real value if testing against a real Datadog account is desired.
Adds support for is_external, username, password, and tags. Fixes #169 Signed-off-by: Mike Fiedler <[email protected]>
|
@miketheman can I get an estimate on timeline for this pull request? the "conflict" is pretty simple to resolve. The dd-agent becomes a switch statement which then calls the current dd-agent renamed dd-agent-linux if it isn't a windows agent or calls the new dd-agent-windows otherwise. |
|
Thanks @EasyAsABC123 ! I think you should remove support of Windows XP which is EOLed and Windows server 2003 which will be EOLed in 3 months (http://chiron.gb2n.org/datadog/eolgoodness/) and for which the latest Agent release will be 5.2.0 (there won't be any further release of the Agent for Windows Server 2003). It would simplify your pull request as you'll be able to get rid of your older_than_windows2003r2 helper. |
Merged upstream changes and new features
|
@remh removed helper and older windows support. |
|
Closed via #210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to install the latest (or locally archieved) datadog windows agent.