-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags to build cryptography
on rpm-x64
#18757
Conversation
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: 4f88409d-9f2f-48be-a349-11ef79e8b544 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
ca5fdc2
to
16cb20f
Compare
RUSTFLAGS
when building python dependenciesRUSTFLAGS
and PIP_NO_BINARY
flags to build cryptography
on rpm-x64
6d1824f
to
7e9283d
Compare
7e9283d
to
8aa0bef
Compare
18af519
to
32a454f
Compare
RUSTFLAGS
and PIP_NO_BINARY
flags to build cryptography
on rpm-x64cryptography
on rpm-x64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also hopeful that an unpatched snowflake
will come in the near future which I'm hoping it will simplify some of this stuff.
What does this PR do?
Add
RUSTFLAGS
,PIP_NO_BINARY
andOPENSSL_DIR
flags to buildcryptography
on rpm-x64Motivation
We would like to bump cryptography in integrations-core. We end up with this error on rpm x64 builds (where pip build the wheel from source I believe, because none are available OOTB):
This is related to pyca/cryptography#8614 (comment)
A job worked here (errors in the other jobs are related to the
cat
commands I added to debug) using my branch in integrations-core with cryptography 41.0.3Additional Notes
I also need
PIP_NO_CACHE_DIR
andPIP_FORCE_REINSTALL
because here we manually install snowflake AND its dependencies (since we blacklist it from the main file), includingcryptography
. Pip builds the wheel in the custom recipe without the flags, so without the link. When we try to build the wheel with the flags,cryptography
is already installed so we just skip it.PIP_FORCE_REINSTALL
is needed to uninstall/reinstall andPIP_NO_CACHE_DIR
to avoid using the existing cached wheel that comes from snowflake, to make sure we build the wheel from source. I could have had the flags to the custom recipe instead but we hope to drop this custom recipe soon (even before we drop rpm x64, thanks to this if this gets merged)I should have a shortcut for
if redhat? && !arm?
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.