Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to build cryptography on rpm-x64 #18757

Merged
merged 21 commits into from
Aug 14, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 11, 2023

What does this PR do?

Add RUSTFLAGS, PIP_NO_BINARY and OPENSSL_DIR flags to build cryptography on rpm-x64

Motivation

We would like to bump cryptography in integrations-core. We end up with this error on rpm x64 builds (where pip build the wheel from source I believe, because none are available OOTB):

            [HealthCheck] I | 2023-08-11T06:28:02+00:00 | Running health on agent
            [HealthCheck] E | 2023-08-11T06:28:14+00:00 | Failed!
            [HealthCheck] E | 2023-08-11T06:28:14+00:00 | The following libraries have unsafe or unmet dependencies:
    --> /opt/datadog-agent/embedded/lib/python3.9/site-packages/cryptography/hazmat/bindings/_rust.abi3.so
            [HealthCheck] E | 2023-08-11T06:28:14+00:00 | The following binaries have unsafe or unmet dependencies:
            [HealthCheck] E | 2023-08-11T06:28:14+00:00 | The following requirements could not be resolved:
    --> libssl.so.1.1
    --> libcrypto.so.1.1
            [HealthCheck] E | 2023-08-11T06:28:14+00:00 | The precise failures were:
    --> /opt/datadog-agent/embedded/lib/python3.9/site-packages/cryptography/hazmat/bindings/_rust.abi3.so
    DEPENDS ON: libssl.so.1.1
      COUNT: 1
      PROVIDED BY: not found
      FAILED BECAUSE: Unresolved dependency
    --> /opt/datadog-agent/embedded/lib/python3.9/site-packages/cryptography/hazmat/bindings/_rust.abi3.so
    DEPENDS ON: libcrypto.so.1.1
      COUNT: 1
      PROVIDED BY: not found
      FAILED BECAUSE: Unresolved dependency
            [HealthCheck] I | 2023-08-11T06:28:14+00:00 | Health check time: 11.3807s
The health check failed! Please see above for important information.

This is related to pyca/cryptography#8614 (comment)

A job worked here (errors in the other jobs are related to the cat commands I added to debug) using my branch in integrations-core with cryptography 41.0.3

Additional Notes

I also need PIP_NO_CACHE_DIR and PIP_FORCE_REINSTALL because here we manually install snowflake AND its dependencies (since we blacklist it from the main file), including cryptography. Pip builds the wheel in the custom recipe without the flags, so without the link. When we try to build the wheel with the flags, cryptography is already installed so we just skip it. PIP_FORCE_REINSTALL is needed to uninstall/reinstall and PIP_NO_CACHE_DIR to avoid using the existing cached wheel that comes from snowflake, to make sure we build the wheel from source. I could have had the flags to the custom recipe instead but we hope to drop this custom recipe soon (even before we drop rpm x64, thanks to this if this gets merged)

I should have a shortcut for if redhat? && !arm?

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@pr-commenter
Copy link

pr-commenter bot commented Aug 11, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4f88409d-9f2f-48be-a349-11ef79e8b544
Baseline: 5d5462e
Comparison: 32a454f
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput +0.47 [-0.78, +1.71] 36.79%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.03] 2.67%
trace_agent_msgpack ingress throughput +0.00 [-0.09, +0.09] 0.39%
trace_agent_json ingress throughput -0.03 [-0.12, +0.06] 32.68%
file_to_blackhole egress throughput -0.12 [-1.20, +0.96] 11.35%
uds_dogstatsd_to_api ingress throughput -0.52 [-1.49, +0.46] 50.33%
tcp_syslog_to_blackhole ingress throughput -0.92 [-1.03, -0.81] 100.00%

@FlorentClarret FlorentClarret force-pushed the florentclarret/bump_cryptography branch from ca5fdc2 to 16cb20f Compare August 11, 2023 09:25
@FlorentClarret FlorentClarret changed the title Add RUSTFLAGS when building python dependencies Add RUSTFLAGS and PIP_NO_BINARY flags to build cryptography on rpm-x64 Aug 11, 2023
@FlorentClarret FlorentClarret force-pushed the florentclarret/bump_cryptography branch from 6d1824f to 7e9283d Compare August 11, 2023 20:22
@FlorentClarret FlorentClarret force-pushed the florentclarret/bump_cryptography branch from 7e9283d to 8aa0bef Compare August 11, 2023 20:23
@FlorentClarret FlorentClarret force-pushed the florentclarret/bump_cryptography branch from 18af519 to 32a454f Compare August 12, 2023 06:25
@FlorentClarret FlorentClarret changed the title Add RUSTFLAGS and PIP_NO_BINARY flags to build cryptography on rpm-x64 Add flags to build cryptography on rpm-x64 Aug 12, 2023
@FlorentClarret FlorentClarret removed request for a team August 12, 2023 09:43
Copy link
Contributor

@alopezz alopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also hopeful that an unpatched snowflake will come in the near future which I'm hoping it will simplify some of this stuff.

@FlorentClarret FlorentClarret merged commit 3d1e2ca into main Aug 14, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/bump_cryptography branch August 14, 2023 07:38
@FlorentClarret FlorentClarret mentioned this pull request Dec 11, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants