Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --no-binary :all: when building cryptography #19617

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Sep 21, 2023

What does this PR do?

Removes --no-binary :all: when building cryptography.

Motivation

Build broken due to a combination of setuptools-scm and --no-binary :all: (pypa/setuptools-scm#918).

Additional Notes

This flag was introduced in #18757, along with others, while trying to fix build problems for cryptography on centos 6. From looking at the commits on that PR, I think that it was just one attempt out of many and it wasn't unclear whether it helped fix the build problem, but we never attempted to remove it once we hit a combination that actually ended up in a successful build. All this to say that it's probably fine to remove it since it was added for avoiding build errors, not runtime errors.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@alopezz alopezz changed the title Attempt: see what happens when we remove --no-binary :all: Remove --no-binary :all: when building cryptography Sep 21, 2023
@alopezz alopezz marked this pull request as ready for review September 21, 2023 09:43
@alopezz alopezz requested a review from a team as a code owner September 21, 2023 09:43
@alopezz alopezz added this to the Triage milestone Sep 21, 2023
@pr-commenter
Copy link

pr-commenter bot commented Sep 21, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ffe5aecc-ee4d-43e9-a817-7eb5a940828e
Baseline: 566f206
Comparison: c5c8023
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +1.42 [+1.28, +1.57] 100.00%
uds_dogstatsd_to_api_nodist ingress throughput +0.81 [+0.70, +0.92] 100.00%
uds_dogstatsd_to_api_nomultivalue ingress throughput +0.80 [-1.40, +3.01] 45.15%
uds_dogstatsd_to_api ingress throughput +0.25 [-1.95, +2.45] 14.78%
file_to_blackhole egress throughput +0.12 [-1.34, +1.58] 10.99%
trace_agent_msgpack ingress throughput +0.00 [-0.13, +0.13] 0.24%
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.05] 29.55%
trace_agent_json ingress throughput -0.01 [-0.14, +0.11] 15.27%
otel_to_otel_logs ingress throughput -0.69 [-2.27, +0.89] 52.87%
file_tree egress throughput -2.96 [-5.16, -0.77] 97.36%

Copy link
Contributor

@vivek-datadog vivek-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this fixes the build issue 🤞

Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alopezz alopezz merged commit 14ed714 into main Sep 21, 2023
@alopezz alopezz deleted the alopez/fix-setuptools-scm-build-problem-attempt branch September 21, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants