pkg/config/legacy: add missing trace agent properties to legacy config converter. #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 56.67% 57.26% +0.59%
==========================================
Files 380 380
Lines 24123 24238 +115
==========================================
+ Hits 13671 13881 +210
+ Misses 9537 9469 -68
+ Partials 915 888 -27
|
|
@olivielpeau can you PTAL if this is more along the lines of what you meant in #2678 (comment)? If yes, I will test this PR directly in trace and potentially merge it if afterwards if all is well with you too and the team. |
gbbr
force-pushed
the
gbbr/trace-config
branch
3 times, most recently
from
85c3f5e to
c70dab8
Compare
gbbr
force-pushed
the
gbbr/trace-config
branch
from
c70dab8 to
a33c06c
Compare
olivielpeau
previously approved these changes
Nov 21, 2018
|
Thanks for looking. I'm going to try it out in trace agent and see if anything is missing. Will ping you on both PRs. |
|
@olivielpeau PTAL. Addressed your comments and submitted another minor fix. Also tried it out on trace agent. Will open PR soon once this gets merged (so I can vendor the commit inside trace-agent). |
olivielpeau
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing trace agent properties to legacy config converter. As a follow-up to #2678