-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit tagging feature #3024
Explicit tagging feature #3024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good to me 👍. @l0k0ms This should be in 6.10 - We'll need to sync to update the doc.
I think this deserves a relnote though.
Codecov Report
@@ Coverage Diff @@
## master #3024 +/- ##
==========================================
+ Coverage 53.42% 53.45% +0.03%
==========================================
Files 532 530 -2
Lines 37811 37948 +137
==========================================
+ Hits 20199 20284 +85
- Misses 16403 16460 +57
+ Partials 1209 1204 -5
|
Relnote added @CharlyF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖 🛫
What does this PR do?
It introduces pod-level and container-level tagging through annotations.
Motivation
Being able to configure per-container and per-pod tags with a more dynamic approach (so we can dispense with rollouts implied by label or configuration change).
Example
The intended usage is: