Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit tagging feature #3024

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Explicit tagging feature #3024

merged 2 commits into from
Feb 14, 2019

Conversation

xlucas
Copy link
Member

@xlucas xlucas commented Feb 11, 2019

What does this PR do?

It introduces pod-level and container-level tagging through annotations.

Motivation

Being able to configure per-container and per-pod tags with a more dynamic approach (so we can dispense with rollouts implied by label or configuration change).

Example

The intended usage is:

metadata:
  annotations:
    ad.datadoghq.com/tags: {"pod_tag": "value", ...}
    ad.datadoghq.com/<container_name>.tags: {"container_tag": "value", ...}

@xlucas xlucas requested a review from a team as a code owner February 11, 2019 18:13
@bits-bot
Copy link
Collaborator

bits-bot commented Feb 11, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me 👍. @l0k0ms This should be in 6.10 - We'll need to sync to update the doc.
I think this deserves a relnote though.

@CharlyF CharlyF added this to the 6.10.0 milestone Feb 11, 2019
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3024 into master will increase coverage by 0.03%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##           master    #3024      +/-   ##
==========================================
+ Coverage   53.42%   53.45%   +0.03%     
==========================================
  Files         532      530       -2     
  Lines       37811    37948     +137     
==========================================
+ Hits        20199    20284      +85     
- Misses      16403    16460      +57     
+ Partials     1209     1204       -5
Impacted Files Coverage Δ
pkg/tagger/collectors/kubelet_extract.go 78.76% <74.07%> (-1.48%) ⬇️
pkg/secrets/check_right.go 26.31% <0%> (-45.12%) ⬇️
pkg/secrets/secrets.go 63.1% <0%> (-8.05%) ⬇️
pkg/forwarder/transaction.go 78.63% <0%> (-4.28%) ⬇️
pkg/autodiscovery/listeners/kube_services.go 34.4% <0%> (-2.81%) ⬇️
pkg/autodiscovery/config_poller.go 30.23% <0%> (-1.87%) ⬇️
pkg/secrets/fetch_secret.go 96.36% <0%> (-0.07%) ⬇️
pkg/util/kubernetes/hpa/hpa.go 100% <0%> (ø) ⬆️
...kg/tagger/collectors/kubernetes_metadata_mapper.go 0% <0%> (ø) ⬆️
pkg/clusteragent/custommetrics/provider.go 61.9% <0%> (ø) ⬆️
... and 8 more

@xlucas
Copy link
Member Author

xlucas commented Feb 12, 2019

Relnote added @CharlyF

Copy link
Contributor

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖 🛫

@xlucas xlucas merged commit 9cff86e into master Feb 14, 2019
@xlucas xlucas deleted the xavier.lucas/tagging-by-annotation branch February 14, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants