update labels/annotations_as_tags on value change

[ahmed-mez]

What does this PR do?

Currently, pod labels_as_tags / annotations_as_tags get collected and set on pod/container creation. FR to be able to update these labels_as_tags / annotations_as_tags when the pod label/annotations values update.

Motivation

Feature request: update the labels programmatically and monitors them using tags

[xlucas]

Digests associated to a pod entity should be removed when the latter expires. This is also something we will want to include in test scenarios.

[xlucas]

LGTM

[hkaj]

Is there a good reason for those hashes to be separate, or can we make a digest of both, get rid of the type, and make tagsDigests be a map[string]string instead?

[ahmed-mez]

that's right, we can calculate a single digest of both labels and annotations and store it in a map[string]string 👍

[hkaj]

I think this could take both annotations and labels, or even the whole metadata object, and return a single string for the pod (and it could be named digestPodMeta in this case). That's just a proposal, might not be the best, but the name digestMap confused me at first because I expected it to digest the whole map and it actually hashes values only.

[ahmed-mez]

what I suggest:

• rename the function to digestMapValues
• add another function digestPodMeta which takes a metadata object as an argument
• digestPodMeta calls digestMapValues twice to calculate digests for labels and annotations
• digestPodMeta returns a single pod digest from both labels and annotations digests

I'd keep the digestMapValues logic (keys sorting and map values hash calculation) in a separate function to avoid duplicating it for 2 maps (labels and annotations) in digestPodMeta.
WDYT?

[hkaj]

That sounds great 👍 let's just make sure to define explicitly in the comment of the digestPodMeta in which order we write annotation and label hashes.

[ahmed-mez]

done 👍

[hkaj]

💯