Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the note about labels and annotations as tags #4706

Closed
wants to merge 2 commits into from

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented May 31, 2019

What does this PR do?

Remove the note about labels and annotations as tags as they became dynamic in Agent 6.12 DataDog/datadog-agent#3253

Motivation

update

Preview link

https://docs-staging.datadoghq.com/ahmed/revert-pod-labels-as-tags-note/agent/autodiscovery/

@ahmed-mez ahmed-mez requested a review from a team as a code owner May 31, 2019 16:35
@ruthnaebeck
Copy link
Contributor

@ahmed-mez - Is this only true for Agent 6.12+? If so, the note should be updated to reflect that.

@l0k0ms
Copy link
Contributor

l0k0ms commented Jun 3, 2019

let's hold on this and merge it after 6.12 and: #4660

@l0k0ms l0k0ms added Agent Do Not Merge Just do not merge this PR :) labels Jun 3, 2019
@l0k0ms l0k0ms closed this Jun 6, 2019
@l0k0ms l0k0ms deleted the ahmed/revert-pod-labels-as-tags-note branch June 6, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Just do not merge this PR :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants