[CWS] add fentry fallback #33825

safchain · 2025-02-07T15:28:23Z

What does this PR do?

Add a fallback to kprobes when the eBPF manager fails to attach fentry.

Remove Setup function of the probe implementations.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

YoannGh · 2025-02-07T17:01:22Z

pkg/security/probe/probe_ebpf.go

 	if err := p.eventStream.Init(p.Manager, p.config.Probe); err != nil {
 		return err
 	}

+	if err := p.initEBPFManager(); err != nil {
+		if !p.config.Probe.EventStreamUseKprobeFallback {


Should we also check whether useFentry is false here in order to avoid reloading twice a failing kprobe mode?

dustmop

LGTM for agent-configuration.

agent-platform-auto-pr · 2025-02-10T18:00:46Z

Uncompressed package size comparison

Comparison with ancestor 834167f2ac33a300e2f2a000cfe5cb95486f0d59

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	865.65MB	865.65MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.42MB	875.41MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.42MB	875.41MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.53MB	56.53MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.12MB	59.12MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.12MB	59.12MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.16MB	854.16MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	863.91MB	863.91MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.04MB	59.04MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	441.05MB	441.05MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	86.41MB	86.41MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	82.68MB	82.68MB	0.50MB
datadog-iot-agent-x86_64-rpm	-0.00MB	✅	86.47MB	86.48MB	0.50MB
datadog-iot-agent-x86_64-suse	-0.00MB	✅	86.47MB	86.47MB	0.50MB
datadog-iot-agent-aarch64-rpm	-0.00MB	✅	82.75MB	82.75MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-02-10T18:04:39Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55634133 --os-family=ubuntu

Note: This applies to commit 0759539

agent-platform-auto-pr · 2025-02-10T18:07:53Z

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.5MiB	858.45MiB	202.83MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	921.71MiB	942.69MiB	308.68MiB	321.56MiB
✅	static_quality_gate_docker_agent_arm64	934.08MiB	952.69MiB	292.66MiB	351.22MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.11GiB	383.75MiB	395.8MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.11GiB	363.73MiB	375.5MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.86MiB	57.88MiB	18.29MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.26MiB	56.27MiB	17.05MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.75MiB	277.7MiB	107.3MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.81MiB	293.73MiB	102.15MiB	112.12MiB

cit-pr-commenter · 2025-02-10T18:36:23Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b1b32888-642b-480e-bc94-c849e33a254d

Baseline: 4c272a6
Comparison: 4c272a6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.78	[-2.29, +3.85]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.43	[+0.38, +0.48]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.14	[-0.77, +1.04]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.03	[-0.89, +0.96]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.87, +0.89]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.63, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.28, +0.27]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.97, +0.94]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.68, +0.63]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.09	[-0.14, -0.04]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	-0.11	[-0.89, +0.68]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.13	[-0.59, +0.34]	1	Logs
➖	quality_gate_idle	memory utilization	-0.23	[-0.26, -0.19]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.30	[-1.07, +0.47]	1	Logs
➖	file_tree	memory utilization	-0.33	[-0.39, -0.27]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

spikat

LGTM but I wonder if we could have a test environment to validate the fallback or not, WDYT?

safchain · 2025-02-12T08:51:09Z

/merge

dd-devflow · 2025-02-12T08:51:16Z

View all feedbacks in Devflow UI.
2025-02-12 08:51:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

2025-02-12 09:04:35 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

#33910 with merge sha 180061d
#33099 with merge sha e2b5053
#32543 with merge sha 48f5652
#33925 with merge sha 28383c5

safchain · 2025-02-12T14:21:03Z

/merge

dd-devflow · 2025-02-12T14:21:08Z

View all feedbacks in Devflow UI.
2025-02-12 14:21:08 UTC ℹ️ Start processing command /merge

2025-02-12 14:21:14 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

2025-02-12 14:57:35 UTC ℹ️ MergeQueue: This merge request was merged

safchain added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Feb 7, 2025

safchain requested review from a team as code owners February 7, 2025 15:28

safchain requested a review from dustmop February 7, 2025 15:28

github-actions bot added component/system-probe medium review PR review might take time labels Feb 7, 2025

YoannGh reviewed Feb 7, 2025

View reviewed changes

dustmop approved these changes Feb 7, 2025

View reviewed changes

safchain force-pushed the safchain/fentry-fallback branch from 3eb88fe to 30c10ac Compare February 10, 2025 17:21

safchain force-pushed the safchain/fentry-fallback branch from 13f9b55 to 403010e Compare February 11, 2025 12:59

spikat approved these changes Feb 11, 2025

View reviewed changes

safchain added ask-review Ask required teams to review this PR and removed ask-review Ask required teams to review this PR labels Feb 11, 2025

YoannGh approved these changes Feb 11, 2025

View reviewed changes

usamasaqib approved these changes Feb 11, 2025

View reviewed changes

paulcacheux approved these changes Feb 12, 2025

View reviewed changes

safchain added 4 commits February 12, 2025 10:27

[CWS] add fentry fallback

93171f1

remove mamager change

8f9f8f9

check useFentry

96fe865

move runtime constant edition

0759539

safchain force-pushed the safchain/fentry-fallback branch from 403010e to 0759539 Compare February 12, 2025 09:27

dd-mergequeue bot merged commit 4c272a6 into main Feb 12, 2025
234 checks passed

dd-mergequeue bot deleted the safchain/fentry-fallback branch February 12, 2025 14:57

github-actions bot added this to the 7.64.0 milestone Feb 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CWS] add fentry fallback #33825

[CWS] add fentry fallback #33825

safchain commented Feb 7, 2025 •

edited

Loading

YoannGh Feb 7, 2025

dustmop left a comment

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 10, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

spikat left a comment

safchain commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 •

edited

Loading

safchain commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 •

edited

Loading

[CWS] add fentry fallback #33825

[CWS] add fentry fallback #33825

Conversation

safchain commented Feb 7, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

YoannGh Feb 7, 2025

Choose a reason for hiding this comment

dustmop left a comment

Choose a reason for hiding this comment

agent-platform-auto-pr bot commented Feb 10, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Feb 10, 2025 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Feb 10, 2025 • edited Loading

Static quality checks ✅

Info

cit-pr-commenter bot commented Feb 10, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

spikat left a comment

Choose a reason for hiding this comment

safchain commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 • edited Loading

safchain commented Feb 12, 2025

dd-devflow bot commented Feb 12, 2025 • edited Loading

safchain commented Feb 7, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 10, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 10, 2025 •

edited

Loading

dd-devflow bot commented Feb 12, 2025 •

edited

Loading

dd-devflow bot commented Feb 12, 2025 •

edited

Loading