Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notify] Allow CI_COMMIT_BRANCH to not exist #33925

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Feb 11, 2025

What does this PR do?

Some errors (1, 2) were due to this as the pipeline was created on a tag and not a branch.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport/7.62.x Automatically create a backport PR to 7.62.x backport/7.63.x Automatically create a backport PR to 7.63.x labels Feb 11, 2025
@CelianR CelianR self-assigned this Feb 11, 2025
@CelianR CelianR requested review from a team as code owners February 11, 2025 13:09
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor f0119e3b897c962b1697dfa1b8e010f86fa98e05

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 865.60MB 865.60MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.12MB 854.12MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 863.87MB 863.87MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.97MB 440.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.36MB 86.36MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.62MB 82.62MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.69MB 82.69MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 55523936 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.44MiB 858.45MiB 202.91MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.66MiB 942.69MiB 308.66MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.04MiB 952.69MiB 292.64MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.73MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.7MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.06MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.74MiB 293.73MiB 102.11MiB 112.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c2970dcc-daca-47cb-bb21-6af724a88a93

Baseline: f0119e3
Comparison: f2e4b47
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.47 [-0.30, +1.24] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.36 [+0.30, +0.43] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.23 [-0.24, +0.70] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.64, +0.75] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.74, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.90, +0.96] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.87, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.27] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.00 [-0.92, +0.92] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.89, +0.89] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_tree memory utilization -0.08 [-0.15, -0.01] 1 Logs
quality_gate_idle memory utilization -0.11 [-0.14, -0.08] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.61 [-0.68, -0.54] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.72 [-5.72, +0.27] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@CelianR
Copy link
Contributor Author

CelianR commented Feb 12, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 12, 2025

View all feedbacks in Devflow UI.
2025-02-12 08:43:37 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.


2025-02-12 09:38:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-devflow dd-devflow bot mentioned this pull request Feb 12, 2025
@dd-mergequeue dd-mergequeue bot merged commit 91fb50c into main Feb 12, 2025
253 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/fix-ci-commit-branch branch February 12, 2025 09:38
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 12, 2025
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.62.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.62.x 7.62.x
# Navigate to the new working tree
cd .worktrees/backport-7.62.x
# Create a new branch
git switch --create backport-33925-to-7.62.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 91fb50ce5882f26e72d8c099bcc192e0d41f7dab
# Push it to GitHub
git push --set-upstream origin backport-33925-to-7.62.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.62.x

Then, create a pull request where the base branch is 7.62.x and the compare/head branch is backport-33925-to-7.62.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.62.x Automatically create a backport PR to 7.62.x backport/7.63.x Automatically create a backport PR to 7.63.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants