-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Automate Releases #450
Conversation
also added `lint` job
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 54 54
Lines 2186 2186
Branches 509 509
=======================================
Hits 1795 1795
Misses 329 329
Partials 62 62 ☔ View full report in Codecov by Sentry. |
…ght out of the builder
also added a modded `publish_layers.sh` script for gitlab
also set run on the pipeline, not on the if
@@ -0,0 +1,177 @@ | |||
stages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ this templating approach!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ and
@@ -0,0 +1,29 @@ | |||
regions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for this PR: I think we probably want a way to remind us if there's a new region added.
Related to this PR: We need to catch up some of the regions before we enable the pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, right now this approach wouldn't work for GovCloud either, since we are setting those regions here.
An ideal solution for another PR would be: in the generator pipeline, list regions and generate this file!
built layers after 1 hour and signed layers after 1 day
also added `needs` for NPM publishing in prod
also added another comment when running the old `publish_prod.sh` script
…o jordan.gonzalez/add-gitlab-ci
…-gitlab-ci' into jordan.gonzalez/add-gitlab-ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🌔
What does this PR do?
Adds GitLab pipeline and migrates current GitHub actions there.

Migrates:
Adds:
Motivation
Automate Layer Releases.
SVLS-4265
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply