Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Automate Releases #450
chore: Automate Releases #450
Changes from 94 commits
2828562
93917c8
bf3e7bc
a1b6373
394dddf
e3146d5
1ce7814
3ef140a
c589b39
cf96abe
311b0af
d0b0967
a41b4c3
c9b314d
d7bd6a0
18518f3
242f01d
58315ab
32f84de
1221726
03cb08a
31bdae7
dc87dfd
5181363
0aada8e
862e4f6
b6ec472
3eb188d
79171f2
b5fba21
f5092f3
30383c3
ea02770
c9538ea
cc1131f
45b61ba
672e301
95fa90d
af6f6a3
ab52615
05ac837
9d96e16
27ecac9
f92a580
0735af3
75659a9
a0ede98
6b9a6ac
7b92a68
a1696a6
4946441
c1fe111
08cd438
87b8c77
1950e9b
dc89ec1
ae55c3d
0d2ffc6
448858e
f2a0cfe
de33970
5f74f2c
9b76af6
f0f36e3
6a01bed
5b4f410
25c100d
d39c67b
16e1190
ad1f639
fe76014
5d24852
12bbb08
871d87b
adc0af5
bbe2bdf
53024d0
23a4a72
48f0fe5
838a0fd
9decfd2
b1f032c
a536278
6fbc8ca
57d6344
f4f183d
cd18bc4
9bbb87c
b78ecc9
314d795
5bcac09
16e6dfc
609e9e8
67b756e
f3783e4
e69de71
fc1b96f
57b902b
864e3f5
ddeed2c
2841208
3a994d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for this PR: I think we probably want a way to remind us if there's a new region added.
Related to this PR: We need to catch up some of the regions before we enable the pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, right now this approach wouldn't work for GovCloud either, since we are setting those regions here.
An ideal solution for another PR would be: in the generator pipeline, list regions and generate this file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ this templating approach!