Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.route tags for API Gateway #584

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

nhulston
Copy link
Contributor

@nhulston nhulston commented Oct 25, 2024

What does this PR do?

Adds http.route tags for Lambdas that were triggered by API Gateway.

  • For APIGW v1, we set the route to the resource
  • For APIGW v2, we set the route to the routeKey

Motivation

These tags are used by API Catalog
https://datadoghq.atlassian.net/browse/SVLS-5779

A similar PR for universal instrumentation (Java, .NET, Golang) is already done: DataDog/datadog-agent@315c38f

See DataDog/datadog-lambda-python#524 for Python changes

Testing Guidelines

Manual tests; updated unit tests and snapshots

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston force-pushed the nicholas.hulston/add-http.route-tags branch from cf3b04d to 54e33f7 Compare October 25, 2024 18:48
@nhulston nhulston marked this pull request as ready for review October 25, 2024 19:03
@nhulston nhulston requested a review from a team as a code owner October 25, 2024 19:03
@nhulston nhulston merged commit 8087c87 into main Oct 29, 2024
25 checks passed
@nhulston nhulston deleted the nicholas.hulston/add-http.route-tags branch October 29, 2024 18:37
@nhulston nhulston mentioned this pull request Nov 21, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants