Add http.route tags for API Gateway
#524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhulston
force-pushed
the
nicholas.hulston/add-httproute-tags
branch
from
7bc663d to
1b7aee3
Compare
11 tasks
purple4reina
approved these changes
Oct 25, 2024
duncanista
reviewed
Oct 28, 2024
duncanista
approved these changes
Oct 28, 2024
wantsui
reviewed
Oct 28, 2024
wantsui
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I defer the serverless portion of the review to @duncanpharvey or anyone else in the Serverless side of things but the test results of http.route look good to me.
avedmala
added a commit
that referenced
this pull request
Nov 18, 2024
* add logic to extract traceID from _datadog header * rename test * fix type * added root arn case * trigger ci * Add `http.route` tags for API Gateway (#524) Add route tags * feat: [SVLS-5677] DynamoDB Stream event span pointers (#522) * trigger ci * use default propagator.extract * lint * lint * updated to use trace/parent hash from _datadog * lint * skip is context complete check * remove unused import * fix legacy lambda parsing with new header * using context object instead of pre-hashed values * fixed trigger tags and tests * pull sfn trace id generation out into a helper * added unit tests * update test data * rename stepfunctions to states * update current serverless version to v1 * Update trigger comment Co-authored-by: kimi <[email protected]> --------- Co-authored-by: Nicholas Hulston <[email protected]> Co-authored-by: Aleksandr Pasechnik <[email protected]> Co-authored-by: kimi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
http.routetags for Lambdas that were triggered by API Gateway.Motivation
These tags are used by API Catalog
https://datadoghq.atlassian.net/browse/SVLS-5779
A similar PR for universal instrumentation (Java, .NET, Golang) is already done: DataDog/datadog-agent@315c38f
See DataDog/datadog-lambda-js#584 for JavaScript changes.
Testing Guidelines
Manual tests; update unit tests and snapshots
Additional Notes
Types of Changes
Check all that apply