Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

config: use shared config for env loading #531

Merged
merged 5 commits into from
Nov 26, 2018
Merged

config: use shared config for env loading #531

merged 5 commits into from
Nov 26, 2018

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Nov 26, 2018 •
edited
Loading

  • Read environment variables into shared config.Datadog
  • Add tests for all environment variable overrides for both .conf and .yaml files
  • Fix flaky tests
  • Name files better
  • Move DynamicConfig into sampler. This configuration is sampler-provided and was confusingly located in the config package.

@gbbr gbbr added this to the 6.8.0 milestone Nov 26, 2018
@gbbr gbbr requested review from AlexJF and LotharSee November 26, 2018 13:33
@gbbr gbbr merged commit be953ea into master Nov 26, 2018
@gbbr gbbr deleted the gbbr/guild-env branch November 26, 2018 16:31
@dalen dalen mentioned this pull request Dec 24, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexJF AlexJF AlexJF approved these changes

@LotharSee LotharSee Awaiting requested review from LotharSee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gbbr @AlexJF