Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

internal/config: allow setting environment using environment variable #548

Merged
merged 3 commits into from
Dec 27, 2018

Conversation

dalen
Copy link

@dalen dalen commented Dec 17, 2018

This fixes #502

@gbbr
Copy link
Contributor

gbbr commented Dec 24, 2018

I thought we agreed within #502 that the problem was resolved and this isn't needed.

@gbbr gbbr changed the title Add ability to set environment using environment variable internal/config: allow setting environment using environment variable Dec 24, 2018
@dalen
Copy link
Author

dalen commented Dec 24, 2018

Well, there is a workaround with some code changes in the application. But I still think it is good to be able to set it on the agent even in docker environments.

You said in that issue

In a next release (soon) most config options will be settable via environment variables too.

So I thought it would get fixed in the env config loading refactoring, #531 but it seems it wasn't, so therefore created this PR.

Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. You're right, this wasn't part of those changes. Let's add it.

@gbbr gbbr added this to the 6.9.0 milestone Dec 24, 2018
@gbbr gbbr merged commit dce7d91 into DataDog:master Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants