[mongo] add tcmalloc metrics #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
pushed a commit
that referenced
this pull request
Oct 16, 2015
[[email protected]] rebased on #1979 → `collect_wiredtiger_metrics` option.
This was referenced Oct 16, 2015
yannmh
force-pushed
the
yann/collect_tcmalloc
branch
from
b0fc02d to
8863ba8
Compare
yannmh
pushed a commit
that referenced
this pull request
Oct 16, 2015
[[email protected]] rebased on #1979 → `collect_wiredtiger_metrics` option.
| "uptime": GAUGE, | ||
| } | ||
|
|
||
| V2_ONLY_METRICS = { |
There was a problem hiding this comment.
I don't think this is the entire list of metrics available only in mongo 2.x. E.g. I don't think that Mongo 3.x will return "cursors.totalOpen" or "cursors.timedOut"
There was a problem hiding this comment.
I just ran some tests against a MongoDB 2.6 and 3.0 instances, the V2_ONLY_METRICS seens exhaustive.
cursors.totalOpen or cursors.timedOut are still part of MongoDB 3.0 as stated in the MongoDB 3.0 documentation
[[email protected]] rebased to sync with MongoDB last changes
Split the metric list in multiple parts: * `COMMON_METRICS`: default metrics to collect * `V2_ONLY_METRICS`: metrics available in MongoDB 2.x only * `TCMALLOC_METRICS`: TCMalloc memory allocator metrics It's easier to assess the check coverage in our CI, and gives more control on the level of metric collection. Create a `collect_tcmalloc_metrics` option (default to False). Extends #1832, thanks a lot @benmccann !
yannmh
force-pushed
the
yann/collect_tcmalloc
branch
from
8863ba8 to
ba8760e
Compare
|
Thanks for your feedback @benmccann. I adressed your comments and rebased the PR. It's ready to be merged now 🚢 |
yannmh
pushed a commit
that referenced
this pull request
Oct 29, 2015
[[email protected]] rebased on #1979 → `collect_wiredtiger_metrics` option.
yannmh
pushed a commit
that referenced
this pull request
Oct 30, 2015
[[email protected]] rebased on #1979 → `collect_wiredtiger_metrics` option.
yannmh
pushed a commit
that referenced
this pull request
Nov 2, 2015
[[email protected]] rebased on #1979 → `wiredtiger` option.
yannmh
pushed a commit
that referenced
this pull request
Dec 21, 2015
[[email protected]] rebased on #1979 → `wiredtiger` option.
yannmh
pushed a commit
that referenced
this pull request
Dec 21, 2015
[[email protected]] rebased on #1979 **Additional changes:** * Add the corresponding `wiredtiger` option in `additional_metrics` * More friendly WiredTiger metric aliases * Switch some WiredTiger metric types from `gauge` to `rate`
yannmh
pushed a commit
that referenced
this pull request
Dec 22, 2015
[[email protected]] rebased on #1979 **Additional changes:** * Add the corresponding `wiredtiger` option in `additional_metrics` * More friendly WiredTiger metric aliases * Switch some WiredTiger metric types from `gauge` to `rate`
yannmh
pushed a commit
that referenced
this pull request
Dec 22, 2015
[[email protected]] rebased on #1979 **Additional changes:** * Add the corresponding `wiredtiger` option in `additional_metrics` * More friendly WiredTiger metric aliases * Switch some WiredTiger metric types from `gauge` to `rate`
yannmh
pushed a commit
that referenced
this pull request
Dec 22, 2015
[[email protected]] rebased on #1979 **Additional changes:** * Add the corresponding `wiredtiger` option in `additional_metrics` * More friendly WiredTiger metric aliases * Switch some WiredTiger metric types from `gauge` to `rate`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased of #1832 on master, thanks a lot @benmccann !
My two cents:
Split the metric list in multiple parts:
COMMON_METRICS: default metrics to collectV2_ONLY_METRICS: metrics available in MongoDB 2.x onlyTCMALLOC_METRICS: TCMalloc memory allocator metricsIt's easier to assess the check coverage in our CI, and gives more
control on the level of metric collection.
Create a
collect_tcmalloc_metricsoption (default to False).