Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "more unix" plugin with some linux metrics. #2202

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

gphat
Copy link
Contributor

@gphat gphat commented Jan 14, 2016

I somehow broke #2030 . Oops.

What's this PR do?

Adds some new system metrics:

  • context switch count (for rates!)
  • processes created count (for rates!)
  • interrupts
  • counts of processes by state, with tags
  • counts of processes by priority, with tags

Motivation

These metrics are used in our existing setup and, from what I can tell, are not available today in Datadog agent. We can get them from specific processes via process.yaml, but not for the whole system!

Notes

I originally tried to add this stuff to unix.py but I'm unable to determine how those metrics end up as things like sys.mem.free and the like. So I settled on making a check that added the metrics I as after. I expect to add more.

Most of these metrics feel very "core" to Linux and therefore seem suitable to be included in something like unix.py. But for now I'll opt to take a conservative approach and assume this will just be a plugin. If you are not interested in having it in the agent, we'll just use it locally.

Lemme know and thanks for looking!

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@remh remh added this to the 5.7.0 milestone Jan 14, 2016
@remh remh self-assigned this Jan 14, 2016
@remh
Copy link

remh commented Jan 14, 2016

The failure in the tests is unrelated and was caused by a change in the version of rubocop. Merging.
Thanks @gphat !

remh pushed a commit that referenced this pull request Jan 14, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Add "more unix" plugin with some linux metrics.
@remh remh merged commit 4454b24 into DataDog:master Jan 14, 2016
@ashb
Copy link

ashb commented Feb 10, 2016

This uses a hard-coded /proc which means it won't work when running in a docker container (which is what we do) -- This was fixed for the normal process check in #2163 one week before this was merged.

I guess we need to make it use a similar config mechanism here, or make this use psutil too?

@gtmtech gtmtech mentioned this pull request Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants