Add "more unix" plugin with some linux metrics. #2202
Merged
+115
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I somehow broke #2030 . Oops.
What's this PR do?
Adds some new system metrics:
Motivation
These metrics are used in our existing setup and, from what I can tell, are not available today in Datadog agent. We can get them from specific processes via
process.yaml
, but not for the whole system!Notes
I originally tried to add this stuff to
unix.py
but I'm unable to determine how those metrics end up as things likesys.mem.free
and the like. So I settled on making a check that added the metrics I as after. I expect to add more.Most of these metrics feel very "core" to Linux and therefore seem suitable to be included in something like
unix.py
. But for now I'll opt to take a conservative approach and assume this will just be a plugin. If you are not interested in having it in the agent, we'll just use it locally.Lemme know and thanks for looking!