Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source and destination folders computation for Android Gradle projects #8190

Merged

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jan 13, 2025

What Does This Do

Does some minor fixes to the logic that determines source and destination folders for Android Gradle projects:

  • looks for Kotlin classes if ${project.buildDir}/tmp/kotlin-classes folder exists; previously only looked for them if the project had kotlin-android plugin, which didn't work sometimes (as the project could be using a different Kotlin plugin, e.g. kotlin-multiplatform
  • besides considering android and android-library plugins, also considers com.android.application and com.android.library plugins (which are aliases for the other two)

Contributor Checklist

Jira ticket: SDTEST-1429

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Jan 13, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/android-gradle-coverage-fix
git_commit_date 1736758880 1736778618
git_commit_sha 8bcee06 561e191
release_version 1.46.0-SNAPSHOT~8bcee06789 1.46.0-SNAPSHOT~561e191472
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736781012 1736781012
ci_job_id 763854759 763854759
ci_pipeline_id 52821542 52821542
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053624
Total [baseline] (8.611 s) : 0, 8611200
Agent [candidate] (1.055 s) : 0, 1054582
Total [candidate] (8.611 s) : 0, 8610921
section iast
Agent [baseline] (1.182 s) : 0, 1182308
Total [baseline] (9.163 s) : 0, 9163245
Agent [candidate] (1.181 s) : 0, 1181116
Total [candidate] (9.205 s) : 0, 9205064
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190773
Total [baseline] (9.164 s) : 0, 9163971
Agent [candidate] (1.192 s) : 0, 1192294
Total [candidate] (9.225 s) : 0, 9225132
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1172135
Total [baseline] (9.195 s) : 0, 9195337
Agent [candidate] (1.18 s) : 0, 1180373
Total [candidate] (9.181 s) : 0, 9180793
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.182 s 128.684 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 137.149 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.172 s 118.511 ms (11.2%)
Total tracing 8.611 s -
Total iast 9.163 s 552.044 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.164 s 552.77 ms (6.4%)
Total iast_TELEMETRY_OFF 9.195 s 584.136 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.181 s 126.535 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 137.712 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.18 s 125.792 ms (11.9%)
Total tracing 8.611 s -
Total iast 9.205 s 594.143 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.225 s 614.211 ms (7.1%)
Total iast_TELEMETRY_OFF 9.181 s 569.873 ms (6.6%)
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.838 ms) : 0, 711838
BytebuddyAgent [candidate] (713.44 ms) : 0, 713440
GlobalTracer [baseline] (255.254 ms) : 0, 255254
GlobalTracer [candidate] (255.606 ms) : 0, 255606
AppSec [baseline] (55.209 ms) : 0, 55209
AppSec [candidate] (56.144 ms) : 0, 56144
Remote Config [baseline] (719.555 µs) : 0, 720
Remote Config [candidate] (731.583 µs) : 0, 732
Telemetry [baseline] (15.617 ms) : 0, 15617
Telemetry [candidate] (13.676 ms) : 0, 13676
section iast
BytebuddyAgent [baseline] (832.013 ms) : 0, 832013
BytebuddyAgent [candidate] (830.387 ms) : 0, 830387
GlobalTracer [baseline] (246.362 ms) : 0, 246362
GlobalTracer [candidate] (246.702 ms) : 0, 246702
AppSec [baseline] (57.883 ms) : 0, 57883
AppSec [candidate] (58.141 ms) : 0, 58141
IAST [baseline] (21.59 ms) : 0, 21590
IAST [candidate] (21.376 ms) : 0, 21376
Remote Config [baseline] (673.196 µs) : 0, 673
Remote Config [candidate] (683.483 µs) : 0, 683
Telemetry [baseline] (8.7 ms) : 0, 8700
Telemetry [candidate] (8.801 ms) : 0, 8801
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.107 ms) : 0, 837107
BytebuddyAgent [candidate] (836.581 ms) : 0, 836581
GlobalTracer [baseline] (248.404 ms) : 0, 248404
GlobalTracer [candidate] (249.817 ms) : 0, 249817
AppSec [baseline] (58.695 ms) : 0, 58695
AppSec [candidate] (58.957 ms) : 0, 58957
IAST [baseline] (21.878 ms) : 0, 21878
IAST [candidate] (22.131 ms) : 0, 22131
Remote Config [baseline] (686.63 µs) : 0, 687
Remote Config [candidate] (696.777 µs) : 0, 697
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (9.049 ms) : 0, 9049
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (824.206 ms) : 0, 824206
BytebuddyAgent [candidate] (829.757 ms) : 0, 829757
GlobalTracer [baseline] (245.575 ms) : 0, 245575
GlobalTracer [candidate] (246.899 ms) : 0, 246899
AppSec [baseline] (57.448 ms) : 0, 57448
AppSec [candidate] (58.219 ms) : 0, 58219
IAST [baseline] (20.726 ms) : 0, 20726
IAST [candidate] (21.038 ms) : 0, 21038
Remote Config [baseline] (651.552 µs) : 0, 652
Remote Config [candidate] (672.246 µs) : 0, 672
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.66 ms) : 0, 8660
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052570
Total [baseline] (10.451 s) : 0, 10450926
Agent [candidate] (1.055 s) : 0, 1055277
Total [candidate] (10.452 s) : 0, 10452222
section appsec
Agent [baseline] (1.19 s) : 0, 1189620
Total [baseline] (10.726 s) : 0, 10726047
Agent [candidate] (1.186 s) : 0, 1186359
Total [candidate] (10.69 s) : 0, 10690174
section iast
Agent [baseline] (1.193 s) : 0, 1193422
Total [baseline] (11.012 s) : 0, 11011918
Agent [candidate] (1.181 s) : 0, 1181056
Total [candidate] (10.919 s) : 0, 10918821
section profiling
Agent [baseline] (1.276 s) : 0, 1276484
Total [baseline] (10.887 s) : 0, 10887155
Agent [candidate] (1.271 s) : 0, 1270631
Total [candidate] (10.866 s) : 0, 10865983
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.19 s 137.051 ms (13.0%)
Agent iast 1.193 s 140.852 ms (13.4%)
Agent profiling 1.276 s 223.914 ms (21.3%)
Total tracing 10.451 s -
Total appsec 10.726 s 275.121 ms (2.6%)
Total iast 11.012 s 560.991 ms (5.4%)
Total profiling 10.887 s 436.228 ms (4.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.186 s 131.082 ms (12.4%)
Agent iast 1.181 s 125.779 ms (11.9%)
Agent profiling 1.271 s 215.354 ms (20.4%)
Total tracing 10.452 s -
Total appsec 10.69 s 237.953 ms (2.3%)
Total iast 10.919 s 466.599 ms (4.5%)
Total profiling 10.866 s 413.762 ms (4.0%)
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.371 ms) : 0, 712371
BytebuddyAgent [candidate] (714.386 ms) : 0, 714386
GlobalTracer [baseline] (255.636 ms) : 0, 255636
GlobalTracer [candidate] (256.163 ms) : 0, 256163
AppSec [baseline] (55.115 ms) : 0, 55115
AppSec [candidate] (55.25 ms) : 0, 55250
Remote Config [baseline] (737.048 µs) : 0, 737
Remote Config [candidate] (720.129 µs) : 0, 720
Telemetry [baseline] (13.765 ms) : 0, 13765
Telemetry [candidate] (13.808 ms) : 0, 13808
section appsec
BytebuddyAgent [baseline] (731.59 ms) : 0, 731590
BytebuddyAgent [candidate] (729.291 ms) : 0, 729291
GlobalTracer [baseline] (253.47 ms) : 0, 253470
GlobalTracer [candidate] (252.762 ms) : 0, 252762
AppSec [baseline] (170.631 ms) : 0, 170631
AppSec [candidate] (170.164 ms) : 0, 170164
IAST [baseline] (19.286 ms) : 0, 19286
IAST [candidate] (20.045 ms) : 0, 20045
Remote Config [baseline] (669.738 µs) : 0, 670
Remote Config [candidate] (657.215 µs) : 0, 657
Telemetry [baseline] (8.608 ms) : 0, 8608
Telemetry [candidate] (8.502 ms) : 0, 8502
section iast
BytebuddyAgent [baseline] (838.044 ms) : 0, 838044
BytebuddyAgent [candidate] (830.916 ms) : 0, 830916
GlobalTracer [baseline] (249.844 ms) : 0, 249844
GlobalTracer [candidate] (246.66 ms) : 0, 246660
AppSec [baseline] (58.753 ms) : 0, 58753
AppSec [candidate] (57.855 ms) : 0, 57855
IAST [baseline] (21.897 ms) : 0, 21897
IAST [candidate] (21.298 ms) : 0, 21298
Remote Config [baseline] (687.314 µs) : 0, 687
Remote Config [candidate] (658.211 µs) : 0, 658
Telemetry [baseline] (9.048 ms) : 0, 9048
Telemetry [candidate] (8.718 ms) : 0, 8718
section profiling
BytebuddyAgent [baseline] (705.701 ms) : 0, 705701
BytebuddyAgent [candidate] (701.632 ms) : 0, 701632
GlobalTracer [baseline] (370.122 ms) : 0, 370122
GlobalTracer [candidate] (368.34 ms) : 0, 368340
AppSec [baseline] (54.192 ms) : 0, 54192
AppSec [candidate] (53.93 ms) : 0, 53930
Remote Config [baseline] (698.214 µs) : 0, 698
Remote Config [candidate] (693.15 µs) : 0, 693
Telemetry [baseline] (8.759 ms) : 0, 8759
Telemetry [candidate] (8.76 ms) : 0, 8760
ProfilingAgent [baseline] (94.809 ms) : 0, 94809
ProfilingAgent [candidate] (95.423 ms) : 0, 95423
Profiling [baseline] (94.834 ms) : 0, 94834
Profiling [candidate] (95.448 ms) : 0, 95448
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-13T14:42:30 2025-01-13T14:49:33
git_branch master nikita-tkachenko/android-gradle-coverage-fix
git_commit_date 1736758880 1736778618
git_commit_sha 8bcee06 561e191
release_version 1.46.0-SNAPSHOT~8bcee06789 1.46.0-SNAPSHOT~561e191472
start_time 2025-01-13T14:42:16 2025-01-13T14:49:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736780129 1736780129
ci_job_id 763854760 763854760
ci_pipeline_id 52821542 52821542
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.75 µs) : 364, 404
.   : milestone, 384,
iast (499.993 µs) : 478, 522
.   : milestone, 500,
iast_FULL (659.292 µs) : 637, 681
.   : milestone, 659,
iast_GLOBAL (530.631 µs) : 508, 553
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (504.863 µs) : 483, 526
.   : milestone, 505,
iast_INACTIVE (460.14 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (496.728 µs) : 475, 519
.   : milestone, 497,
tracing (460.662 µs) : 438, 483
.   : milestone, 461,
section candidate
no_agent (387.98 µs) : 368, 408
.   : milestone, 388,
iast (504.889 µs) : 483, 527
.   : milestone, 505,
iast_FULL (660.287 µs) : 639, 682
.   : milestone, 660,
iast_GLOBAL (525.293 µs) : 504, 547
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (497.27 µs) : 476, 519
.   : milestone, 497,
iast_INACTIVE (460.283 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (488.779 µs) : 467, 510
.   : milestone, 489,
tracing (456.798 µs) : 436, 477
.   : milestone, 457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.75 µs [363.582 µs, 403.918 µs] -
iast 499.993 µs [478.267 µs, 521.719 µs] 116.243 µs (30.3%)
iast_FULL 659.292 µs [637.416 µs, 681.167 µs] 275.542 µs (71.8%)
iast_GLOBAL 530.631 µs [508.267 µs, 552.996 µs] 146.882 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 504.863 µs [483.459 µs, 526.266 µs] 121.113 µs (31.6%)
iast_INACTIVE 460.14 µs [438.761 µs, 481.518 µs] 76.39 µs (19.9%)
iast_TELEMETRY_OFF 496.728 µs [474.794 µs, 518.661 µs] 112.978 µs (29.4%)
tracing 460.662 µs [438.44 µs, 482.884 µs] 76.912 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 387.98 µs [367.92 µs, 408.039 µs] -
iast 504.889 µs [482.987 µs, 526.792 µs] 116.91 µs (30.1%)
iast_FULL 660.287 µs [638.555 µs, 682.019 µs] 272.307 µs (70.2%)
iast_GLOBAL 525.293 µs [503.747 µs, 546.838 µs] 137.313 µs (35.4%)
iast_HARDCODED_SECRET_DISABLED 497.27 µs [475.766 µs, 518.773 µs] 109.29 µs (28.2%)
iast_INACTIVE 460.283 µs [438.563 µs, 482.003 µs] 72.303 µs (18.6%)
iast_TELEMETRY_OFF 488.779 µs [467.136 µs, 510.421 µs] 100.799 µs (26.0%)
tracing 456.798 µs [436.188 µs, 477.409 µs] 68.818 µs (17.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.375 ms) : 1356, 1394
.   : milestone, 1375,
appsec (1.775 ms) : 1751, 1799
.   : milestone, 1775,
appsec_no_iast (1.749 ms) : 1724, 1775
.   : milestone, 1749,
iast (1.528 ms) : 1505, 1550
.   : milestone, 1528,
profiling (1.562 ms) : 1537, 1587
.   : milestone, 1562,
tracing (1.512 ms) : 1488, 1537
.   : milestone, 1512,
section candidate
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.749 ms) : 1725, 1773
.   : milestone, 1749,
appsec_no_iast (1.765 ms) : 1740, 1790
.   : milestone, 1765,
iast (1.518 ms) : 1495, 1541
.   : milestone, 1518,
profiling (1.575 ms) : 1550, 1600
.   : milestone, 1575,
tracing (1.485 ms) : 1460, 1511
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.375 ms [1.356 ms, 1.394 ms] -
appsec 1.775 ms [1.751 ms, 1.799 ms] 399.878 µs (29.1%)
appsec_no_iast 1.749 ms [1.724 ms, 1.775 ms] 374.483 µs (27.2%)
iast 1.528 ms [1.505 ms, 1.55 ms] 152.601 µs (11.1%)
profiling 1.562 ms [1.537 ms, 1.587 ms] 187.466 µs (13.6%)
tracing 1.512 ms [1.488 ms, 1.537 ms] 137.161 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.383 ms] -
appsec 1.749 ms [1.725 ms, 1.773 ms] 385.646 µs (28.3%)
appsec_no_iast 1.765 ms [1.74 ms, 1.79 ms] 401.536 µs (29.5%)
iast 1.518 ms [1.495 ms, 1.541 ms] 154.364 µs (11.3%)
profiling 1.575 ms [1.55 ms, 1.6 ms] 211.538 µs (15.5%)
tracing 1.485 ms [1.46 ms, 1.511 ms] 122.075 µs (9.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/android-gradle-coverage-fix
git_commit_date 1736758880 1736778618
git_commit_sha 8bcee06 561e191
release_version 1.46.0-SNAPSHOT~8bcee06789 1.46.0-SNAPSHOT~561e191472
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736780671 1736780671
ci_job_id 763854761 763854761
ci_pipeline_id 52821542 52821542
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
iast (18.789 s) : 18789000, 18789000
.   : milestone, 18789000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
.   : milestone, 17962000,
profiling (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
tracing (14.836 s) : 14836000, 14836000
.   : milestone, 14836000,
section candidate
no_agent (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
appsec (14.931 s) : 14931000, 14931000
.   : milestone, 14931000,
iast (19.075 s) : 19075000, 19075000
.   : milestone, 19075000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
.   : milestone, 17989000,
profiling (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
tracing (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.438 s [15.438 s, 15.438 s] -
appsec 14.965 s [14.965 s, 14.965 s] -473.0 ms (-3.1%)
iast 18.789 s [18.789 s, 18.789 s] 3.351 s (21.7%)
iast_GLOBAL 17.962 s [17.962 s, 17.962 s] 2.524 s (16.3%)
profiling 15.02 s [15.02 s, 15.02 s] -418.0 ms (-2.7%)
tracing 14.836 s [14.836 s, 14.836 s] -602.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.961 s [14.961 s, 14.961 s] -
appsec 14.931 s [14.931 s, 14.931 s] -30.0 ms (-0.2%)
iast 19.075 s [19.075 s, 19.075 s] 4.114 s (27.5%)
iast_GLOBAL 17.989 s [17.989 s, 17.989 s] 3.028 s (20.2%)
profiling 15.146 s [15.146 s, 15.146 s] 185.0 ms (1.2%)
tracing 14.946 s [14.946 s, 14.946 s] -15.0 ms (-0.1%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~561e191472, baseline=1.46.0-SNAPSHOT~8bcee06789
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.355 ms) : 2312, 2398
.   : milestone, 2355,
iast (2.107 ms) : 2053, 2162
.   : milestone, 2107,
iast_GLOBAL (2.156 ms) : 2101, 2210
.   : milestone, 2156,
profiling (1.976 ms) : 1932, 2021
.   : milestone, 1976,
tracing (1.959 ms) : 1917, 2001
.   : milestone, 1959,
section candidate
no_agent (1.479 ms) : 1467, 1491
.   : milestone, 1479,
appsec (2.376 ms) : 2333, 2419
.   : milestone, 2376,
iast (2.117 ms) : 2062, 2172
.   : milestone, 2117,
iast_GLOBAL (2.156 ms) : 2101, 2211
.   : milestone, 2156,
profiling (1.989 ms) : 1944, 2034
.   : milestone, 1989,
tracing (1.96 ms) : 1918, 2002
.   : milestone, 1960,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 2.355 ms [2.312 ms, 2.398 ms] 877.376 µs (59.4%)
iast 2.107 ms [2.053 ms, 2.162 ms] 629.624 µs (42.6%)
iast_GLOBAL 2.156 ms [2.101 ms, 2.21 ms] 678.023 µs (45.9%)
profiling 1.976 ms [1.932 ms, 2.021 ms] 498.663 µs (33.7%)
tracing 1.959 ms [1.917 ms, 2.001 ms] 481.422 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.491 ms] -
appsec 2.376 ms [2.333 ms, 2.419 ms] 896.962 µs (60.6%)
iast 2.117 ms [2.062 ms, 2.172 ms] 638.047 µs (43.1%)
iast_GLOBAL 2.156 ms [2.101 ms, 2.211 ms] 677.197 µs (45.8%)
profiling 1.989 ms [1.944 ms, 2.034 ms] 510.122 µs (34.5%)
tracing 1.96 ms [1.918 ms, 2.002 ms] 481.124 µs (32.5%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 82e3386 into master Jan 14, 2025
176 of 177 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/android-gradle-coverage-fix branch January 14, 2025 11:13
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 14, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 31, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.25.4` -> `2.26.0` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.45.2` -> `1.46.0` |
| [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.45.2` -> `1.46.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.30.9` -> `2.30.10` |

---

### Release Notes

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29)

##### Features

- Add firestoreInDatastoreMode for datastore emulator
([#&#8203;1698](googleapis/java-datastore#1698))
([50f106d](googleapis/java-datastore@50f106d))

##### Dependencies

- Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0
([#&#8203;1725](googleapis/java-datastore#1725))
([1cbaf22](googleapis/java-datastore@1cbaf22))

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0):
1.46.0

##### Breaking Changes

> \[!WARNING]
> jnr-unixsocket is now an external dependency of dd-trace-ot and must
be included when deploying dd-trace-ot.

> \[!NOTE]
> The API `TracerScope.setAsync(boolean)`, used to manually control
asynchronous span propagation, does no more apply to the scope instance
but to the active span scope.

##### Components

##### Application Security Management (IAST)

- 🐛 Fix String.replace instrumentation for IAST
([#&#8203;8281](DataDog/dd-trace-java#8281) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Apply the standard nomenclature to the stacktrace configs
([#&#8203;8244](DataDog/dd-trace-java#8244) -
[@&#8203;jandro996](https://github.com/jandro996))
- 🐛 Exclude false positive weak randomness
([#&#8203;8232](DataDog/dd-trace-java#8232) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Propagation of translateEscapes of String class
([#&#8203;8186](DataDog/dd-trace-java#8186) -
[@&#8203;sezen-datadog](https://github.com/sezen-datadog))
- ✨ Add security control metrics
([#&#8203;8175](DataDog/dd-trace-java#8175) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Increase IAST propagation to StringBuffer setLength
([#&#8203;8128](DataDog/dd-trace-java#8128) -
[@&#8203;Mariovido](https://github.com/Mariovido))
- ✨ Add IAST taint tracking for DB values
([#&#8203;8072](DataDog/dd-trace-java#8072) -
[@&#8203;Mariovido](https://github.com/Mariovido))

##### Application Security Management (WAF)

- 🐛 Prevents a NPE when there is no subscriber for user events
([#&#8203;8258](DataDog/dd-trace-java#8258) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Apply the standard nomenclature to the stacktrace configs
([#&#8203;8244](DataDog/dd-trace-java#8244) -
[@&#8203;jandro996](https://github.com/jandro996))
- 🐛 Ensure cached subscriptions are cleared on reconfiguration via
RC ([#&#8203;8229](DataDog/dd-trace-java#8229)
-
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Add support for session tracking in Vertx
([#&#8203;8167](DataDog/dd-trace-java#8167) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Create span tag: \_dd.appsec.rasp.timeout
([#&#8203;8269](DataDog/dd-trace-java#8269) -
[@&#8203;Mariovido](https://github.com/Mariovido))

##### Build & Tooling

- 🐛 Ensure shaded helpers have unique names when injected into
class-loaders
([#&#8203;8192](DataDog/dd-trace-java#8192) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Configuration at Runtime

- 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer
([#&#8203;8176](DataDog/dd-trace-java#8176) -
[@&#8203;mhlidd](https://github.com/mhlidd))

##### Continuous Integration Visibility

- 🧹 Generalize TestRetryPolicy to TestExecutionPolicy
([#&#8203;8302](DataDog/dd-trace-java#8302) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🧹 Parallelize CI Visibility settings requests
([#&#8203;8299](DataDog/dd-trace-java#8299) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🧹 Generalize test retry logic
([#&#8203;8289](DataDog/dd-trace-java#8289) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🧹 Generalize tests skipping logic
([#&#8203;8288](DataDog/dd-trace-java#8288) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler
in favor of isSkippable
([#&#8203;8286](DataDog/dd-trace-java#8286) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨⚡ Optimize Git repository information computation
([#&#8203;8270](DataDog/dd-trace-java#8270) -
[@&#8203;dougqh](https://github.com/dougqh))
- ✨ Always request known tests from the backend
([#&#8203;8268](DataDog/dd-trace-java#8268) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Fix NPE when trying to get retry analyzer in Test NG
([#&#8203;8253](DataDog/dd-trace-java#8253) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Set test framework and test framework version tags atomically
([#&#8203;8252](DataDog/dd-trace-java#8252) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Add debug logging to Android Gradle module layout logic
([#&#8203;8251](DataDog/dd-trace-java#8251) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Fix source and destination folders computation for Android
Gradle projects
([#&#8203;8190](DataDog/dd-trace-java#8190) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Add basic Scala Weaver sbt support
([#&#8203;8189](DataDog/dd-trace-java#8189) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Implement impacted tests detection
([#&#8203;8188](DataDog/dd-trace-java#8188) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))

##### Data Streams Monitoring

- ✨ Change hash computation for protobuf to better represent
impacting changes + save proto number in schema
([#&#8203;8201](DataDog/dd-trace-java#8201) -
[@&#8203;vandonr](https://github.com/vandonr))

##### Database Monitoring

- Add peer service tag in dbm sql commenter
([#&#8203;7913](DataDog/dd-trace-java#7913) -
[@&#8203;jordan-wong](https://github.com/jordan-wong))

##### Dynamic Instrumentation

- ✨ Add support for SymDB to scan directories
([#&#8203;8306](DataDog/dd-trace-java#8306) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add SymDB report for any jar scanning failures
([#&#8203;8300](DataDog/dd-trace-java#8300) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Use two budgets depending on type
([#&#8203;8283](DataDog/dd-trace-java#8283) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- ✨ Institute a 10 snapshot per probe per trace budget
([#&#8203;8277](DataDog/dd-trace-java#8277) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- 🐛 Avoid double snapshots for Exception Replay
([#&#8203;8273](DataDog/dd-trace-java#8273) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Simplify code origins. Separate out snapshot generation.
([#&#8203;8263](DataDog/dd-trace-java#8263) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- ✨ Add Exception probe custom instrumentation
([#&#8203;8230](DataDog/dd-trace-java#8230) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Enhance log probes to honor debug session tags
([#&#8203;8215](DataDog/dd-trace-java#8215) -
[@&#8203;evanchooly](https://github.com/evanchooly))
- 🐛 Don't redact env tokens from debugger probe snapshots
([#&#8203;8211](DataDog/dd-trace-java#8211) -
[@&#8203;watson](https://github.com/watson))
- ✨⚡ Move Trace/SpanId capture at commit time
([#&#8203;8184](DataDog/dd-trace-java#8184) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Capture values at entry for method probe
([#&#8203;8169](DataDog/dd-trace-java#8169) -
[@&#8203;jpbempel](https://github.com/jpbempel))

##### JMX fetch

- 🐛 Mute JMXFetch Shutdown in progress error
([#&#8203;8068](DataDog/dd-trace-java#8068) -
[@&#8203;ygree](https://github.com/ygree))

##### OpenTracing

- ⚠️🧹 Make jnr-unixsocket an explicit dependency of
dd-trace-ot
([#&#8203;8307](DataDog/dd-trace-java#8307) -
[@&#8203;mcculls](https://github.com/mcculls))

##### Profiling

- 🐛 Avoid unsupported API call for creating folders on windows
([#&#8203;8304](DataDog/dd-trace-java#8304) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Tag profiles for serverless
([#&#8203;8279](DataDog/dd-trace-java#8279) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ add queue type and length to queue events
([#&#8203;8242](DataDog/dd-trace-java#8242) -
[@&#8203;richardstartin](https://github.com/richardstartin))
- 🐛 TempLocationManager Fixes and Improvements
([#&#8203;8191](DataDog/dd-trace-java#8191) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Bump ddprof to 1.18.0
([#&#8203;8173](DataDog/dd-trace-java#8173) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- ✨ Report profiler initialization and configuration errors to
telemetry
([#&#8203;8171](DataDog/dd-trace-java#8171) -
[@&#8203;jbachorik](https://github.com/jbachorik))

##### Telemetry

- ✨ Add pending traces report in tracer flares
([#&#8203;8053](DataDog/dd-trace-java#8053) -
[@&#8203;mhlidd](https://github.com/mhlidd))

##### Testing

- ✨ Test http server requests in parallel
([#&#8203;8222](DataDog/dd-trace-java#8222) -
[@&#8203;amarziali](https://github.com/amarziali))

##### Trace context propagation

- ✨ Add non default propagator registration
([#&#8203;8310](DataDog/dd-trace-java#8310) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

##### Tracer core

- ✨ Probe for existence of IBMSASL or ACCP security providers
([#&#8203;8276](DataDog/dd-trace-java#8276) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨⚡ Overhead improvement to agent feedback based sampling
([#&#8203;8265](DataDog/dd-trace-java#8265) -
[@&#8203;dougqh](https://github.com/dougqh))
- 🧹 Move async propagation API from scope to tracer
([#&#8203;8231](DataDog/dd-trace-java#8231) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨ Introduce context propagation API
([#&#8203;8161](DataDog/dd-trace-java#8161) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨🧪 Use env-entry to add tags per webapp deployment
([#&#8203;8138](DataDog/dd-trace-java#8138) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Introduce context helpers API
([#&#8203;8134](DataDog/dd-trace-java#8134) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨ Support IPv6 values for `DD_AGENT_HOST` and
`DD_TRACE_AGENT_URL`
([#&#8203;7984](DataDog/dd-trace-java#7984) -
[@&#8203;mhlidd](https://github.com/mhlidd))

##### Instrumentations

##### Apache HttpComponents

- 🐛 Properly finish spans and support latest apache httpclient5
([#&#8203;8272](DataDog/dd-trace-java#8272) -
[@&#8203;amarziali](https://github.com/amarziali))

##### AWS Lambda instrumentation

- 🐛 Properly capture lambda payloads for all handler types.
([#&#8203;8264](DataDog/dd-trace-java#8264) -
[@&#8203;purple4reina](https://github.com/purple4reina))

##### AWS S3 instrumentation

- 💡 Create S3 instrumentation + add span pointers
([#&#8203;8075](DataDog/dd-trace-java#8075) -
[@&#8203;nhulston](https://github.com/nhulston))

##### AWS SDK instrumentation

- 🐛 Revert "Add avoid double instrumenting lambda non-streaming
handlers."
([#&#8203;8247](DataDog/dd-trace-java#8247) -
[@&#8203;nhulston](https://github.com/nhulston))

##### Cassandra

- ✨ Allow extracting keyspace from statement result
([#&#8203;8239](DataDog/dd-trace-java#8239) -
[@&#8203;amarziali](https://github.com/amarziali))

##### Core Java language instrumentation

- ✨ Propagation of translateEscapes of String class
([#&#8203;8186](DataDog/dd-trace-java#8186) -
[@&#8203;sezen-datadog](https://github.com/sezen-datadog))

##### Eclipse Vert.x instrumentation

- 🐛 Fix vertx worker propagation and error handling
([#&#8203;8237](DataDog/dd-trace-java#8237) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Support vertx 5
([#&#8203;8220](DataDog/dd-trace-java#8220) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add support for session tracking in Vertx
([#&#8203;8167](DataDog/dd-trace-java#8167) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))

##### Kafka instrumentation

- 🐛 Prevent possible NPE calculating Kafka record header size
([#&#8203;8292](DataDog/dd-trace-java#8292) -
[@&#8203;ygree](https://github.com/ygree))

##### Mule instrumentation

- 🐛 Fix crash using Mule with JPMS
([#&#8203;8187](DataDog/dd-trace-java#8187) -
[@&#8203;amarziali](https://github.com/amarziali))

##### Protocol Buffer instrumentation

- ✨ Change hash computation for protobuf to better represent
impacting changes + save proto number in schema
([#&#8203;8201](DataDog/dd-trace-java#8201) -
[@&#8203;vandonr](https://github.com/vandonr))

##### Spring instrumentation

- 🐛 Preserve getQualifier from spring scheduling runnables
([#&#8203;8293](DataDog/dd-trace-java#8293) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants