Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Configure supported Node.js version range using repository variables #5323

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 26, 2025

What does this PR do?

Configure supported Node.js version range using repository variables

Currently, the following repository variables are created:

  • ACTIVE_LTS (set to 22 as of this commit)
  • NESTEST_MAINTENANCE_LTS (set to 20 as of this commit)
  • OLDEST_MAINTENANCE_LTS (set to 18 as of this commit)

Motivation

Make it easier to upgrade to newer major Node.js versions when they are released.

Copy link
Collaborator Author

watson commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson force-pushed the watson/clean-up-gh-action-node-install2 branch from 940f23f to a12813d Compare February 26, 2025 12:34
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 26, 2025

Datadog Report

Branch report: watson/clean-up-gh-action-node-install2
Commit report: 15293bf
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 65 Passed, 0 Skipped, 0s Total Time

@watson watson force-pushed the watson/clean-up-gh-action-node-install2 branch 2 times, most recently from d03c782 to ddff6e8 Compare February 26, 2025 12:45
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-02-27 05:03:49

Comparing candidate commit 0b5e376 in PR branch watson/clean-up-gh-action-node-install2 with baseline commit 9bc5d34 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

@watson watson changed the base branch from watson/clean-up-gh-action-node-install to graphite-base/5323 February 26, 2025 12:53
@watson watson force-pushed the graphite-base/5323 branch from 3c1b176 to fc07a2b Compare February 26, 2025 12:53
@watson watson force-pushed the watson/clean-up-gh-action-node-install2 branch from ddff6e8 to 9746735 Compare February 26, 2025 12:53
@watson watson changed the base branch from graphite-base/5323 to watson/clean-up-gh-action-node-install February 26, 2025 12:54
Copy link

Overall package size

Self size: 8.8 MB
Deduped: 95 MB
No deduping: 95.52 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (fc07a2b) to head (9746735).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           watson/clean-up-gh-action-node-install    #5323      +/-   ##
==========================================================================
+ Coverage                                   80.44%   80.49%   +0.04%     
==========================================================================
  Files                                         492      490       -2     
  Lines                                       21879    21822      -57     
==========================================================================
- Hits                                        17600    17565      -35     
+ Misses                                       4279     4257      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watson watson force-pushed the watson/clean-up-gh-action-node-install2 branch from 9746735 to 02874ec Compare February 26, 2025 13:09
Base automatically changed from watson/clean-up-gh-action-node-install to master February 26, 2025 14:15
Currently, the following repository variables are created:

- `ACTIVE_LTS` (set to `22` as of this commit)
- `NESTEST_MAINTENANCE_LTS` (set to `20` as of this commit)
- `OLDEST_MAINTENANCE_LTS` (set to `18` as of this commit)
@watson watson force-pushed the watson/clean-up-gh-action-node-install2 branch from 02874ec to 0b5e376 Compare February 27, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant