Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run some GH action jobs on the latest Node.js version as well #5325

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 26, 2025

What does this PR do?

All the jobs that are currently testing all all supported Node.js versions (18, 20, 22) has now been amended to also test on the latest Node.js version as well (23).

Motivation

Node.js 23 is currently a major blind spot for us as we're not testing on it.

Additional Notes

We should strongly consider if there's other tests that we want to run on all supported Node.js versions.

Copy link
Collaborator Author

watson commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson self-assigned this Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

Overall package size

Self size: 8.81 MB
Deduped: 95.01 MB
No deduping: 95.53 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (9bc5d34) to head (73581cf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5325   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         485      485           
  Lines       21811    21811           
=======================================
  Hits        17602    17602           
  Misses       4209     4209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 26, 2025

Datadog Report

Branch report: watson/ci-test-latest
Commit report: f7f8bc8
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 14m 25.79s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-02-27 05:03:49

Comparing candidate commit 73581cf in PR branch watson/ci-test-latest with baseline commit 9bc5d34 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

Base automatically changed from watson/clean-up-gh-action-node-install to master February 26, 2025 14:15
All the jobs that are currently testing all all supported Node.js
versions has now been amended to also test on the latest Node.js version
as well.
@watson watson force-pushed the watson/ci-test-latest branch from a479669 to 73581cf Compare February 27, 2025 04:52
@watson watson marked this pull request as ready for review February 27, 2025 05:48
@watson watson requested review from a team as code owners February 27, 2025 05:49
@watson watson merged commit bc1450a into master Feb 27, 2025
396 checks passed
@watson watson deleted the watson/ci-test-latest branch February 27, 2025 13:16
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
)

All the jobs that are currently testing all all supported Node.js
versions has now been amended to also test on the latest Node.js version
as well.
@juan-fernandez juan-fernandez mentioned this pull request Feb 28, 2025
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
)

All the jobs that are currently testing all all supported Node.js
versions has now been amended to also test on the latest Node.js version
as well.
@juan-fernandez juan-fernandez mentioned this pull request Feb 28, 2025
juan-fernandez pushed a commit that referenced this pull request Feb 28, 2025
)

All the jobs that are currently testing all all supported Node.js
versions has now been amended to also test on the latest Node.js version
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants