Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update for 7.48 #15585

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

vivek-datadog
Copy link
Contributor

@vivek-datadog vivek-datadog commented Aug 16, 2023

What does this PR do?

Update dependencies of integrations-core repo via ddev

Motivation

7.48 agent release

Additional Notes

Postgres has an issue in master (started failing with pipeline of pr15524), seems to be a regression and I have notified the developer in #database-monitoring

As this failure is irrespective of the dependency update, please ignore this failure for the current pr review

=================================== FAILURES ===================================
______________ test_statement_samples_main_collection_rate_limit _______________
tests/test_statements.py:1399: in test_statement_samples_main_collection_rate_limit
    assert max_collections / 2.0 <= len(metrics) <= max_collections
E   AssertionError: assert 3 <= 2
E    +  where 3 = len([MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=21.673202514648438, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False), MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=2.8886795043945312, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False), MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=4.341840744018555, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False)])
- generated xml file: /home/runner/work/integrations-core/integrations-core/postgres/.junit/test-unit-py3.9-14.0.xml -
=========================== short test summary info ============================
FAILED tests/test_statements.py::test_statement_samples_main_collection_rate_limit - AssertionError: assert 3 <= 2
 +  where 3 = len([MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=21.673202514648438, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False), MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=2.8886795043945312, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False), MetricStub(name='dd.postgres.collect_statement_samples.time', type=5, value=4.341840744018555, tags=['foo:bar', 'port:5432', 'db:datadog_test', 'agent_hostname:stubbed.hostname'], hostname='stubbed.hostname', device=None, flush_first_value=False)])
============= 1 failed, 219 passed, 3 skipped in 175.93s (0:02:55) =============

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@vivek-datadog vivek-datadog force-pushed the vivek-datadog/7.48.x-deps-update branch from ced8a56 to 6a689f7 Compare August 16, 2023 12:05
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #15585 (b218ca5) into master (fc38712) will increase coverage by 1.24%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
amazon_msk 89.07% <ø> (ø)
datadog_checks_base 89.62% <ø> (+9.12%) ⬆️
datadog_checks_dev 82.51% <ø> (+0.07%) ⬆️
ibm_was 96.08% <ø> (ø)
kafka_consumer 93.38% <ø> (ø)
redisdb 87.78% <ø> (ø)
sqlserver 87.54% <ø> (-0.08%) ⬇️
ssh_check 91.58% <ø> (ø)
vertica 98.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vivek-datadog vivek-datadog marked this pull request as ready for review August 16, 2023 12:16
@vivek-datadog vivek-datadog requested review from a team as code owners August 16, 2023 12:16
FlorentClarret
FlorentClarret previously approved these changes Aug 16, 2023
@github-actions
Copy link

Test Results

     75 files       75 suites   2h 45m 42s ⏱️
2 159 tests 2 122 ✔️      36 💤 1
8 704 runs  7 653 ✔️ 1 050 💤 1

For more details on these failures, see this check.

Results for commit b218ca5.

@vivek-datadog
Copy link
Contributor Author

Docs build failing in master as well. Reference pipeline

@vivek-datadog vivek-datadog merged commit 1a52082 into master Aug 16, 2023
@vivek-datadog vivek-datadog deleted the vivek-datadog/7.48.x-deps-update branch August 16, 2023 15:26
@vivek-datadog vivek-datadog mentioned this pull request Aug 16, 2023
3 tasks
@FlorentClarret FlorentClarret mentioned this pull request Aug 17, 2023
3 tasks
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants