Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade pydantic to 2.0.2 #15596

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Downgrade pydantic to 2.0.2 #15596

merged 1 commit into from
Aug 17, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 17, 2023 •
edited
Loading

What does this PR do?

Downgrade pydantic to 2.0.2

Motivation

Additional Notes

I'll open another PR to exclude this dependency from the ddev command until we stop supporting centos 6

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret force-pushed the florentclarret/base/downgrade_pydantic branch from 5977d69 to 2e26c82 Compare August 17, 2023 07:01
@ghost ghost added the documentation label Aug 17, 2023
@FlorentClarret FlorentClarret marked this pull request as ready for review August 17, 2023 07:03
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 17, 2023 07:03
@FlorentClarret FlorentClarret mentioned this pull request Aug 17, 2023
Merged
3 tasks
@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Merging #15596 (2e26c82) into master (14a02fc) will increase coverage by 1.24%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_base 89.62% <ø> (+9.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Test Results

       4 files         4 suites   4m 19s ⏱️
1 141 tests 1 124 ✔️   17 💤 0 ❌
4 536 runs  3 789 ✔️ 747 💤 0 ❌

Results for commit 2e26c82.

♻️ This comment has been updated with latest results.

iliakur
iliakur approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pydantic V2: the gift that keeps on giving 😂

@FlorentClarret
Copy link
Member Author

Pydantic V2: the gift that keeps on giving 😂

You mean centos 6

@FlorentClarret FlorentClarret merged commit 0a1cc57 into master Aug 17, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/base/downgrade_pydantic branch August 17, 2023 08:32
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

Assignees
No one assigned
Labels
base_package dependencies documentation qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @iliakur @vivek-datadog