-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the upgrade-python script #16000
Improve the upgrade-python script #16000
Conversation
acd00af
to
8500f5a
Compare
4c8b579
to
5c17719
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple suggestions, nothing major. Will approve once we settle on something for the hatch.toml updates
028f85b
to
db8f43f
Compare
db8f43f
to
e74b53b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, just one simplification proposal left to consider.
What does this PR do?
Improve the upgrade-python script to:
pyproject.toml
filessetup.py
files (if any)pyproject.toml
file to bump the versions for ruff and blackMotivation
Additional Notes
upgrade_python
tests #16019 to be merged firstReview checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.