Use a dummy repository to run the upgrade_python tests
#16019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
3 tasks
FlorentClarret
force-pushed
the
florentclarret/ddev/upgrade_tests
branch
2 times, most recently
from
417d691 to
a0c49c2
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
FlorentClarret
force-pushed
the
florentclarret/ddev/upgrade_tests
branch
from
a0c49c2 to
3a22d4f
Compare
3 tasks
alopezz
reviewed
Oct 16, 2023
Comment on lines
12
to
21
| for entry in fake_repo.path.iterdir(): | ||
| config_file = entry / 'hatch.toml' | ||
| if not config_file.is_file(): | ||
| continue | ||
|
|
||
| for i, line in enumerate(config_file.read_text().splitlines()): | ||
| if line.startswith('python = [') and PYTHON_VERSION in line: | ||
| if line.startswith('python = [') and old_version in line: | ||
| changes[config_file].append(i) | ||
|
|
||
| minimum_changes = sum(map(len, changes.values())) |
There was a problem hiding this comment.
It might be worth dropping this loop? IIUC it's only used to make an assertion on the number after Passed: in the output, and since the output is deterministic now we might be able to drop that (we're already asserting that it equals 2 now).
There was a problem hiding this comment.
Good catch! Updated
FlorentClarret
force-pushed
the
florentclarret/ddev/upgrade_tests
branch
from
3a22d4f to
e9e18c5
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/upgrade_tests
branch
from
e9e18c5 to
4b0ffd5
Compare
FlorentClarret
force-pushed
the
florentclarret/ddev/upgrade_tests
branch
from
4b0ffd5 to
774f273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a dummy repository to run the
upgrade_pythontestsMotivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.