disk check: rename whitelist/blacklist to include/exclude #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ofek
previously requested changes
Sep 18, 2020
albertvaka
force-pushed
the
albertvaka/disk-check-include-exclude
branch
from
fa660af to
07cc7d9
Compare
albertvaka
force-pushed
the
albertvaka/disk-check-include-exclude
branch
from
c4db6cd to
5bf53ab
Compare
Codecov Report
|
mx-psi
requested changes
Sep 21, 2020
datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/config.py
Outdated
Show resolved
Hide resolved
albertvaka
force-pushed
the
albertvaka/disk-check-include-exclude
branch
from
5bf53ab to
8328f49
Compare
|
#7648 adds new options that need to be renamed too. |
|
There are conflicts on the PR |
…ck-include-exclude # Conflicts: # disk/datadog_checks/disk/disk.py # disk/tests/test_filter.py # disk/tests/test_unit.py
albertvaka
force-pushed
the
albertvaka/disk-check-include-exclude
branch
from
249494b to
f333c3b
Compare
|
Updated the PR to include the new |
mx-psi
approved these changes
Sep 25, 2020
mgarabed
approved these changes
Sep 29, 2020
albertvaka
added a commit
that referenced
this pull request
Sep 30, 2020
Fixes deprecation warnings added by myself in PR #7627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename, keeping compatibility with the old names and adding a deprecation warning. We already had some deprecation warnings, so I've put them all together.