Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config option rename refactor #7690

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Fix config option rename refactor #7690

merged 2 commits into from
Sep 30, 2020

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Sep 30, 2020 •
edited
Loading

What does this PR do?

  • Fix deprecation warnings being utterly broken.
  • Fix passing empty lists which were evaluated falsey in the or chain.

@albertvaka
Fix deprecation warnings being broken
6238e1f 
Fixes deprecation warnings added by myself in PR #7627
@albertvaka albertvaka requested review from a team as code owners September 30, 2020 12:47
@ghost ghost added the integration/disk label Sep 30, 2020
KSerrania
KSerrania previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #7690 into master will increase coverage by 6.13%.
The diff coverage is 80.00%.

Impacted Files Coverage Δ
disk/datadog_checks/disk/disk.py 86.31% <80.00%> (+0.21%) ⬆️
hdfs_datanode/tests/test_integration.py
elastic/datadog_checks/elastic/metrics.py
...cs_fargate/datadog_checks/ecs_fargate/__about__.py
istio/datadog_checks/istio/__init__.py
...tadog_checks/dev/tooling/configuration/template.py
php_fpm/datadog_checks/php_fpm/__init__.py
...adog_checks/powerdns_recursor/powerdns_recursor.py
teamcity/datadog_checks/teamcity/__about__.py
elastic/tests/test_metrics.py
... and 860 more

@albertvaka albertvaka changed the title [disk] Fix deprecation warnings being broken [disk] Fix renames done in #7627 Sep 30, 2020
@ofek ofek changed the title [disk] Fix renames done in #7627 Fix config option rename refactor Sep 30, 2020
ofek
ofek approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the title based on https://datadoghq.dev/integrations-core/guidelines/pr/#title

@albertvaka albertvaka merged commit a9caf4b into master Sep 30, 2020
@albertvaka albertvaka deleted the albertvaka/disk-fix-deprecation branch September 30, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@ofek ofek ofek approved these changes

@KSerrania KSerrania KSerrania approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/disk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albertvaka @mgarabed @ofek @KSerrania