Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct timestamp in queue backend #2521

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Oct 2, 2023

Summary

  • Pass down timestamp when creating EVM queue.
  • Use timestamp as backend vicinity to use set timestamp as in construct_block
  • Some smart contract are using https://github.com/DeFiPages/Decentralized-Crypto-Casino/blob/main/src/backend/contracts/Roulette.sol timestamp as randomness and this leads to different result/gas usage between TX applied in queue and in construct_block.
  • Fixes TXs going above block gas limit. As we were only checking TXs total gas used while queueing the TXs, it was within bounds in queue but going randomly above while constructing block.

sieniven
sieniven previously approved these changes Oct 3, 2023
@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Oct 3, 2023
src/validation.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl merged commit c425dc1 into master Oct 4, 2023
@prasannavl prasannavl deleted the fix_queue_timestamp branch October 4, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants