Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency regression in latest releases #108

Closed
dhleong opened this issue Oct 24, 2024 · 5 comments
Closed

Latency regression in latest releases #108

dhleong opened this issue Oct 24, 2024 · 5 comments

Comments

@dhleong
Copy link

dhleong commented Oct 24, 2024

Hello! I've been using v3 in CI for quite some time, but when I went to set up a new project I thought I'd dust off the cobwebs and clean up some warnings that github was showing about old versions. I have not tried to bisect or anything, but version 12.5 took 2 minutes to run (!), and most of it appeared to be just hanging after the "post" step of writing to cache. I downgraded to 3.5 (which includes version updates, at least) and it was back to running almost instantaneously. Is this something you're seeing elsewhere as well, or is it something peculiar about my setup?

Thanks for your help and all your work on these actions!

@frenchy64
Copy link
Contributor

I'm also seeing this.

Here's a build that pauses for 2m even after a cache hit: https://github.com/threatgrid/ctia/actions/runs/11637562591/job/32410961520?pr=1453#step:6:20

Possibly related, here's another build that saves a cache that seems to have already been a cache hit: https://github.com/threatgrid/ctia/actions/runs/11598161623/job/32293388110#step:6:24

@frenchy64
Copy link
Contributor

frenchy64 commented Nov 1, 2024

FWIW the symptoms remind me of actions/cache#597

The ocaml action added explicit exit calls after saving the cache:

msys2 also has a similar fix, they observed the problem started with the Node 16=>20 upgrade.

@frenchy64
Copy link
Contributor

frenchy64 commented Nov 2, 2024

@dhleong Could you try 2d31e3e via:

DeLaGuardo/setup-clojure@2d31e3ee6005571f8b20ab9c0827f29238f58d88

EDIT: updated the SHA

@DeLaGuardo
Copy link
Owner

@dhleong Please try the new 12.6 release and let me know if you still expirience this issue. Huge shout out to @frenchy64 for the fix.

@dhleong
Copy link
Author

dhleong commented Nov 8, 2024

That seems to have fixed it for me! Thank you both 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants