-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: too slow cleanup #1578
Comments
Reference to a possibly relevant issue: actions/cache#597 |
I worked around this problem with this approach: ocaml/setup-ocaml#724 |
818449 |
We are hitting the same issue at https://github.com/msys2/setup-msys2, 2 minutes hangs after everything is executed and a cache was saved before. I did some testing and I can confirm that downgrading to node16 from node20 fixes the issue (can anyone confirm this?). So it seems like a bug to me. I can also confirm that calling |
It's definitely a bug, but it's weird how changing the runtime changes the behaviour. I will look for the cause. |
I don't know much about node, but using |
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing. See actions/toolkit#1578 for the upstream issue. Work around by forcing node to exit. Fixes msys2#346
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing. See actions/toolkit#1578 for the upstream issue. Work around by forcing node to exit. Fixes msys2#346
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing. See actions/toolkit#1578 for the upstream issue. Work around by forcing node to exit. Fixes msys2#346
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing. See actions/toolkit#1578 for the upstream issue. Work around by forcing node to exit. Fixes #346
* Use process.exit() to mitigate actions/toolkit#1578 * package, upgrade dependencies, rev 2.0.1 * use node20 locally * ci-bump * trim trailing whitespace * repackage
this appears to be affecting steps using |
For anybody else running into this: the 2m delay on save went away when I switched to explicit save/restore on v4 (but not v3). |
Thank you, @rmnoon. It worked! |
This is still present in |
Not sure but it seems like it could be due to this:
|
Also running into this ~2m hang using |
I'm opening this issue as a blank issue because it's still not clear if this is a bug!
For some reason, calling the cache save function in the post phase seems to cause a lot of blank time after uploading the cache. This did not happen until a few months ago, if I remember correctly. I just want to check if the actions team has a clear idea of what caused this.
The text was updated successfully, but these errors were encountered: